From: Luca Weiss <luca.weiss@fairphone.com>
To: cros-qcom-dts-watchers@chromium.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>
Subject: [PATCH v2 2/7] nvmem: qfprom: Mark core clk as optional
Date: Tue, 19 Sep 2023 14:45:56 +0200 [thread overview]
Message-ID: <20230919-fp5-initial-v2-2-14bb7cedadf5@fairphone.com> (raw)
In-Reply-To: <20230919-fp5-initial-v2-0-14bb7cedadf5@fairphone.com>
On some platforms like sc7280 on non-ChromeOS devices the core clock
cannot be touched by Linux so we cannot provide it. Mark it as optional
as accessing qfprom for reading works without it but we still prohibit
writing if we cannot provide the clock.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
drivers/nvmem/qfprom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index 14814cba2dd6..525be03b7bba 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -423,12 +423,12 @@ static int qfprom_probe(struct platform_device *pdev)
if (IS_ERR(priv->vcc))
return PTR_ERR(priv->vcc);
- priv->secclk = devm_clk_get(dev, "core");
+ priv->secclk = devm_clk_get_optional(dev, "core");
if (IS_ERR(priv->secclk))
return dev_err_probe(dev, PTR_ERR(priv->secclk), "Error getting clock\n");
- /* Only enable writing if we have SoC data. */
- if (priv->soc_data)
+ /* Only enable writing if we have SoC data and a valid clock */
+ if (priv->soc_data && priv->secclk)
econfig.reg_write = qfprom_reg_write;
}
--
2.42.0
next prev parent reply other threads:[~2023-09-19 12:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 12:45 [PATCH v2 0/7] Initial support for the Fairphone 5 smartphone Luca Weiss
2023-09-19 12:45 ` [PATCH v2 1/7] arm64: dts: qcom: sc7280: Mark some nodes as 'reserved' Luca Weiss
2023-09-19 12:45 ` Luca Weiss [this message]
2023-09-19 14:15 ` [PATCH v2 2/7] nvmem: qfprom: Mark core clk as optional Doug Anderson
2023-09-19 12:45 ` [PATCH v2 3/7] arm64: dts: qcom: pm7250b: make SID configurable Luca Weiss
2023-09-19 12:52 ` Krzysztof Kozlowski
2023-09-19 12:45 ` [PATCH v2 4/7] arm64: dts: qcom: pm8350c: Add flash led node Luca Weiss
2023-09-19 12:45 ` [PATCH v2 5/7] dt-bindings: pinctrl: qcom,sc7280: Allow gpio-reserved-ranges Luca Weiss
2023-09-26 19:06 ` Luca Weiss
2023-09-27 8:57 ` Linus Walleij
2023-09-19 12:46 ` [PATCH v2 6/7] dt-bindings: arm: qcom: Add QCM6490 Fairphone 5 Luca Weiss
2023-09-19 12:53 ` Krzysztof Kozlowski
2023-09-19 12:46 ` [PATCH v2 7/7] arm64: dts: qcom: qcm6490: Add device-tree for " Luca Weiss
2023-09-19 12:54 ` Krzysztof Kozlowski
2023-09-20 15:07 ` Konrad Dybcio
2023-09-20 18:58 ` (subset) [PATCH v2 0/7] Initial support for the Fairphone 5 smartphone Bjorn Andersson
2023-09-25 11:24 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919-fp5-initial-v2-2-14bb7cedadf5@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).