* [PATCH] pinctrl: pinctrl-aspeed-g6: Add more settings for USB2AHP function
@ 2023-09-20 10:33 Joe Wang
2023-09-25 13:15 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Joe Wang @ 2023-09-20 10:33 UTC (permalink / raw)
To: andrew, linus.walleij, joel
Cc: linux-aspeed, openbmc, linux-gpio, linux-arm-kernel, linux-kernel
AST2600 USB2AHP (USB PortA: PCIe EHCI to PHY) function needs to set the
register SCUC20[16]. Set it to enable the PCIe EHCI device on PCIe bus.
Besides, also add USB2AHP signal expressions into pin declarations.
Signed-off-by: Joe Wang <joe_wang@aspeedtech.com>
---
drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c
index 80838dc54b3a..d376fa7114d1 100644
--- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c
+++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c
@@ -1592,9 +1592,10 @@ SIG_EXPR_LIST_DECL_SEMG(A4, USB2ADPDP, USBA, USB2ADP, USB2ADP_DESC,
SIG_DESC_SET(SCUC20, 16));
SIG_EXPR_LIST_DECL_SEMG(A4, USB2ADDP, USBA, USB2AD, USB2AD_DESC);
SIG_EXPR_LIST_DECL_SEMG(A4, USB2AHDP, USBA, USB2AH, USB2AH_DESC);
-SIG_EXPR_LIST_DECL_SEMG(A4, USB2AHPDP, USBA, USB2AHP, USB2AHP_DESC);
+SIG_EXPR_LIST_DECL_SEMG(A4, USB2AHPDP, USBA, USB2AHP, USB2AHP_DESC,
+ SIG_DESC_SET(SCUC20, 16));
PIN_DECL_(A4, SIG_EXPR_LIST_PTR(A4, USB2ADPDP), SIG_EXPR_LIST_PTR(A4, USB2ADDP),
- SIG_EXPR_LIST_PTR(A4, USB2AHDP));
+ SIG_EXPR_LIST_PTR(A4, USB2AHDP), SIG_EXPR_LIST_PTR(A4, USB2AHPDP));
#define B4 253
SIG_EXPR_LIST_DECL_SEMG(B4, USB2ADPDN, USBA, USB2ADP, USB2ADP_DESC);
@@ -1602,7 +1603,7 @@ SIG_EXPR_LIST_DECL_SEMG(B4, USB2ADDN, USBA, USB2AD, USB2AD_DESC);
SIG_EXPR_LIST_DECL_SEMG(B4, USB2AHDN, USBA, USB2AH, USB2AH_DESC);
SIG_EXPR_LIST_DECL_SEMG(B4, USB2AHPDN, USBA, USB2AHP, USB2AHP_DESC);
PIN_DECL_(B4, SIG_EXPR_LIST_PTR(B4, USB2ADPDN), SIG_EXPR_LIST_PTR(B4, USB2ADDN),
- SIG_EXPR_LIST_PTR(B4, USB2AHDN));
+ SIG_EXPR_LIST_PTR(B4, USB2AHDN), SIG_EXPR_LIST_PTR(B4, USB2AHPDN));
GROUP_DECL(USBA, A4, B4);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-aspeed-g6: Add more settings for USB2AHP function
2023-09-20 10:33 [PATCH] pinctrl: pinctrl-aspeed-g6: Add more settings for USB2AHP function Joe Wang
@ 2023-09-25 13:15 ` Linus Walleij
2023-09-26 1:16 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2023-09-25 13:15 UTC (permalink / raw)
To: Joe Wang
Cc: andrew, joel, linux-aspeed, openbmc, linux-gpio, linux-arm-kernel,
linux-kernel
On Wed, Sep 20, 2023 at 12:33 PM Joe Wang <joe_wang@aspeedtech.com> wrote:
> AST2600 USB2AHP (USB PortA: PCIe EHCI to PHY) function needs to set the
> register SCUC20[16]. Set it to enable the PCIe EHCI device on PCIe bus.
> Besides, also add USB2AHP signal expressions into pin declarations.
>
> Signed-off-by: Joe Wang <joe_wang@aspeedtech.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-aspeed-g6: Add more settings for USB2AHP function
2023-09-25 13:15 ` Linus Walleij
@ 2023-09-26 1:16 ` Andrew Jeffery
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2023-09-26 1:16 UTC (permalink / raw)
To: Linus Walleij, Joe Wang
Cc: linux-aspeed, andrew, openbmc, linux-kernel, linux-gpio, joel,
linux-arm-kernel
On Mon, 2023-09-25 at 15:15 +0200, Linus Walleij wrote:
> On Wed, Sep 20, 2023 at 12:33 PM Joe Wang <joe_wang@aspeedtech.com> wrote:
>
> > AST2600 USB2AHP (USB PortA: PCIe EHCI to PHY) function needs to set the
> > register SCUC20[16]. Set it to enable the PCIe EHCI device on PCIe bus.
> > Besides, also add USB2AHP signal expressions into pin declarations.
> >
> > Signed-off-by: Joe Wang <joe_wang@aspeedtech.com>
>
> Patch applied!
Thanks. I hope to improve my review responsiveness for Aspeed patches
over recent times.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-26 1:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-20 10:33 [PATCH] pinctrl: pinctrl-aspeed-g6: Add more settings for USB2AHP function Joe Wang
2023-09-25 13:15 ` Linus Walleij
2023-09-26 1:16 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).