From: Herve Codina <herve.codina@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Randy Dunlap <rdunlap@infradead.org>,
Takashi Iwai <tiwai@suse.com>, Simon Horman <horms@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-gpio@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
netdev@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Eric Dumazet <edumazet@google.com>, Andrew Lunn <andrew@lunn.ch>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
alsa-devel@alsa-project.org, Paolo Abeni <pabeni@redhat.com>,
Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Shengjiu Wan g <shengjiu.wang@gmail.com>,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org,
Li Yang <leoyang.li@nxp.com>, Qiang Zhao <qiang.zhao@nxp.com>
Subject: Re: [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
Date: Fri, 22 Sep 2023 15:45:46 +0200 [thread overview]
Message-ID: <20230922154546.4ca18b6f@bootlin.com> (raw)
In-Reply-To: <169538601225.2919383.2942072541503354871.robh@kernel.org>
Hi Rob,
On Fri, 22 Sep 2023 07:33:32 -0500
Rob Herring <robh@kernel.org> wrote:
> On Fri, 22 Sep 2023 09:59:00 +0200, Herve Codina wrote:
> > The Lantiq PEF2256 is a framer and line interface component designed to
> > fulfill all required interfacing between an analog E1/T1/J1 line and the
> > digital PCM system highway/H.100 bus.
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> > ---
> > .../bindings/net/lantiq,pef2256.yaml | 214 ++++++++++++++++++
> > 1 file changed, 214 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: '$ref' should not be valid under {'const': '$ref'}
> hint: Standard unit suffix properties don't need a type $ref
> from schema $id: http://devicetree.org/meta-schemas/core.yaml#
>
The '-bps' suffix was added recently in
https://github.com/devicetree-org/dt-schema/
commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second")
This commit is not yet present in any dt-schema release.
Should I update my patch (ie. removing $ref) right now even if this update will
make the last dt-schema release not happy ?
Regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-09-22 13:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 7:58 [PATCH v6 00/30] Add support for QMC HDLC, framer infrastructure and PEF2256 framer Herve Codina
2023-09-22 7:58 ` [PATCH v6 01/30] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Herve Codina
2023-09-22 7:58 ` [PATCH v6 02/30] soc: fsl: cpm1: qmc: " Herve Codina
2023-09-22 7:58 ` [PATCH v6 03/30] soc: fsl: cpm1: qmc: Fix rx channel reset Herve Codina
2023-09-22 7:58 ` [PATCH v6 04/30] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Herve Codina
2023-09-22 7:58 ` [PATCH v6 05/30] soc: fsl: cpm1: qmc: Remove inline function specifiers Herve Codina
2023-09-22 7:58 ` [PATCH v6 06/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Fix example property name Herve Codina
2023-09-22 7:58 ` [PATCH v6 07/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add 'additionalProperties: false' in child nodes Herve Codina
2023-09-22 7:58 ` [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC Herve Codina
2023-09-22 21:22 ` Rob Herring
2023-09-23 17:39 ` Krzysztof Kozlowski
2023-09-25 8:17 ` Herve Codina
2023-09-25 8:21 ` Krzysztof Kozlowski
2023-09-25 10:27 ` Herve Codina
2023-09-25 10:44 ` Krzysztof Kozlowski
2023-09-25 13:50 ` Herve Codina
2023-09-26 20:59 ` Krzysztof Kozlowski
2023-09-27 7:24 ` Herve Codina
2023-09-22 7:58 ` [PATCH v6 09/30] soc: fsl: cpm1: qmc: Add support for child devices Herve Codina
2023-09-22 7:58 ` [PATCH v6 10/30] net: wan: Add support for QMC HDLC Herve Codina
2023-09-22 7:58 ` [PATCH v6 11/30] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2023-09-22 7:58 ` [PATCH v6 12/30] soc: fsl: cpm1: qmc: Introduce available timeslots masks Herve Codina
2023-09-22 7:58 ` [PATCH v6 13/30] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Herve Codina
2023-09-22 7:58 ` [PATCH v6 14/30] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Herve Codina
2023-09-22 7:58 ` [PATCH v6 15/30] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Herve Codina
2023-09-22 7:58 ` [PATCH v6 16/30] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Herve Codina
2023-09-22 7:58 ` [PATCH v6 17/30] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Herve Codina
2023-09-22 7:58 ` [PATCH v6 18/30] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Herve Codina
2023-09-22 7:58 ` [PATCH v6 19/30] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Herve Codina
2023-09-22 7:58 ` [PATCH v6 20/30] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Herve Codina
2023-09-22 7:58 ` [PATCH v6 21/30] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Herve Codina
2023-09-22 7:58 ` [PATCH v6 22/30] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Herve Codina
2023-09-22 7:58 ` [PATCH v6 23/30] wan: qmc_hdlc: Add runtime timeslots changes support Herve Codina
2023-09-22 7:58 ` [PATCH v6 24/30] net: wan: Add framer framework support Herve Codina
2023-09-22 7:59 ` [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Herve Codina
2023-09-22 12:33 ` Rob Herring
2023-09-22 13:45 ` Herve Codina [this message]
2023-09-22 19:45 ` Rob Herring
2023-09-22 7:59 ` [PATCH v6 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer Herve Codina
2023-09-22 7:59 ` [PATCH v6 27/30] pinctrl: Add support for the Lantic PEF2256 pinmux Herve Codina
2023-09-22 7:59 ` [PATCH v6 28/30] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-09-22 7:59 ` [PATCH v6 29/30] ASoC: codecs: Add support for the framer codec Herve Codina
2023-09-22 7:59 ` [PATCH v6 30/30] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922154546.4ca18b6f@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=horms@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).