From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958DBE6FE2F for ; Fri, 22 Sep 2023 13:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234097AbjIVNqC (ORCPT ); Fri, 22 Sep 2023 09:46:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234146AbjIVNqB (ORCPT ); Fri, 22 Sep 2023 09:46:01 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C98492; Fri, 22 Sep 2023 06:45:53 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 6BC371BF20D; Fri, 22 Sep 2023 13:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695390352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3d45HSdjEBrGWXzT/hFE6ZoKYqY81rYCMtjLk2B/bLE=; b=biE04lp+7hE+NLdqozy2BgZPaAjb3vaTtdsBnKCNRXF0qN2XFtgDbT6n4cqLkcqbHptxLb oeMOmF7eHyF3aNQjMyD5QaHQjivx7ot6sdz0fFd0QcreP+88erVcjSDntCACDudD3RcyQH iK/3cWyQ7W7XAH8Riv34zdtaG/ZaF9U8gRbBkmmXP9wtu9Dpmv+8fBGDH2uHlFgTVuaf+D vUEEo2o7OwBll3KiAvIkjzGSfu3326QoSexo+bH5ppzRDvkVMmXLebD7B12+Z2XnIyyhNX ouCNBvOA0rABVPgSWhVwNkW32WK4XjYvnXpRZzPaNCdSCfw9y1M3ExfRT98Eow== Date: Fri, 22 Sep 2023 15:45:46 +0200 From: Herve Codina To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, Randy Dunlap , Takashi Iwai , Simon Horman , Jaroslav Kysela , Liam Girdwood , Thomas Petazzoni , linux-gpio@vger.kernel.org, Krzysztof Kozlowski , netdev@vger.kernel.org, Fabio Estevam , Eric Dumazet , Andrew Lunn , Christophe JAILLET , Christophe Leroy , Nicolin Chen , Conor Dooley , Mark Brown , Linus Walleij , alsa-devel@alsa-project.org, Paolo Abeni , Lee Jones , linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Xiubo Li , Rob Herring , Shengjiu Wan g , linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, Li Yang , Qiang Zhao Subject: Re: [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Message-ID: <20230922154546.4ca18b6f@bootlin.com> In-Reply-To: <169538601225.2919383.2942072541503354871.robh@kernel.org> References: <20230922075913.422435-1-herve.codina@bootlin.com> <20230922075913.422435-26-herve.codina@bootlin.com> <169538601225.2919383.2942072541503354871.robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Rob, On Fri, 22 Sep 2023 07:33:32 -0500 Rob Herring wrote: > On Fri, 22 Sep 2023 09:59:00 +0200, Herve Codina wrote: > > The Lantiq PEF2256 is a framer and line interface component designed to > > fulfill all required interfacing between an analog E1/T1/J1 line and the > > digital PCM system highway/H.100 bus. > > > > Signed-off-by: Herve Codina > > Reviewed-by: Christophe Leroy > > --- > > .../bindings/net/lantiq,pef2256.yaml | 214 ++++++++++++++++++ > > 1 file changed, 214 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: '$ref' should not be valid under {'const': '$ref'} > hint: Standard unit suffix properties don't need a type $ref > from schema $id: http://devicetree.org/meta-schemas/core.yaml# > The '-bps' suffix was added recently in https://github.com/devicetree-org/dt-schema/ commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second") This commit is not yet present in any dt-schema release. Should I update my patch (ie. removing $ref) right now even if this update will make the last dt-schema release not happy ? Regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com