From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Prathamesh Shete <pshete@nvidia.com>
Cc: <linus.walleij@linaro.org>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <linux-gpio@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] pinctrl: tegra: Add support to display pin function
Date: Mon, 25 Sep 2023 18:30:49 +0200 [thread overview]
Message-ID: <20230925183049.10a40546@booty> (raw)
In-Reply-To: <20230714113547.15384-1-pshete@nvidia.com>
Hello Prathamesh Shete,
On Fri, 14 Jul 2023 17:05:47 +0530
Prathamesh Shete <pshete@nvidia.com> wrote:
> The current function for a given pin is not displayed via the debugfs.
> Add support to display the current function that is set for each pin.
>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
While testing a Tegra20-based custom board I found a regression which
according to my bisecting appears starting with this patch (commit
d1cd5b51bc91 upstream).
The symptom is that i2c3 is not working anymore, the I2C lines being
always high. No other known issues at the moment.
The board is built around an Avionic Design Tamonten SOM:
arch/arm/boot/dts/nvidia/tegra20-tamonten.dtsi, which has in the
&state_default node:
dtf {
nvidia,pins = "dtf";
nvidia,function = "i2c3";
};
But on top of that the board dts has:
&state_default {
dtf {
nvidia,pins = "dtf";
nvidia,function = "i2c3";
nvidia,pull = <TEGRA_PIN_PULL_NONE>;
nvidia,tristate = <TEGRA_PIN_DISABLE>;
};
};
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 4547cf66d03b..cb1d67239cd0 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -96,6 +96,7 @@ static const struct cfg_param {
> {"nvidia,slew-rate-falling", TEGRA_PINCONF_PARAM_SLEW_RATE_FALLING},
> {"nvidia,slew-rate-rising", TEGRA_PINCONF_PARAM_SLEW_RATE_RISING},
> {"nvidia,drive-type", TEGRA_PINCONF_PARAM_DRIVE_TYPE},
> + {"nvidia,function", TEGRA_PINCONF_PARAM_FUNCTION},
FYI, I reduced your patch to only this line plus the one in the
pinctrl-tegra.h and the problem appears as well.
This is all the info I have at the moment. Can you provide more info on
what could be going on or how to investigate?
I am available to share more info as needed.
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-09-25 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:55 [PATCH] pinctrl: tegra: Add support to display pin function Prathamesh Shete
2023-07-12 15:05 ` Thierry Reding
2023-07-13 8:21 ` [PATCH v2] " Prathamesh Shete
2023-07-14 9:47 ` Thierry Reding
2023-07-14 10:22 ` Jon Hunter
2023-07-14 11:35 ` [PATCH v3] " Prathamesh Shete
2023-07-20 19:35 ` Linus Walleij
2023-09-25 16:30 ` Luca Ceresoli [this message]
2023-09-27 8:54 ` Linus Walleij
2023-09-28 6:53 ` Luca Ceresoli
2023-09-29 12:26 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925183049.10a40546@booty \
--to=luca.ceresoli@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).