From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F75CE7B05 for ; Thu, 28 Sep 2023 06:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbjI1Gx1 (ORCPT ); Thu, 28 Sep 2023 02:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230270AbjI1Gx0 (ORCPT ); Thu, 28 Sep 2023 02:53:26 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C2B7AF; Wed, 27 Sep 2023 23:53:24 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 65E3940007; Thu, 28 Sep 2023 06:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695884003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OReqblEEvau13fBxegnIsM+9N/VACcGD37SP4szyU/I=; b=TaUHaVYt9TnFTD/8oZWmCi+lYprkZJyCoeWm15WUr1DXd8mVexfw3JkiJMj0QyFQj+Upzp MHcylsujykkGzk9TPSMLRRxb9GPxGxQhh7A5/qgb2bpyNHVNzKHFFKXIKn9fSZ9FWd3uI5 dh0QSP9nBCrBVk0emU6PtdcSozbV2Wj7RdEAUODzQ7WBTOMQgjSPfzjMPW56gJ3LxV1vlC e1UaeTIY2+hgAdQlp72UkvdA2eERdcG2K8vh7EKoZ3xz0syWJaEKK+9o/YJXnqYVQb2bqw 5badb6K6nmMF1hwVCe3G+xgsE8xMDdMWMckDwbyfLbyQT8LV78tUobwRlT5IGQ== Date: Thu, 28 Sep 2023 08:53:19 +0200 From: Luca Ceresoli To: Linus Walleij Cc: Prathamesh Shete , thierry.reding@gmail.com, jonathanh@nvidia.com, linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] pinctrl: tegra: Add support to display pin function Message-ID: <20230928085319.0b09bf7d@booty> In-Reply-To: References: <0cf720bf-ae4b-5780-bda4-5c9bbb2d1d67@nvidia.com> <20230714113547.15384-1-pshete@nvidia.com> <20230925183049.10a40546@booty> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: luca.ceresoli@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hello Linus, Prathamesh, On Wed, 27 Sep 2023 10:54:15 +0200 Linus Walleij wrote: > On Mon, Sep 25, 2023 at 6:30=E2=80=AFPM Luca Ceresoli wrote: >=20 > > The symptom is that i2c3 is not working anymore, the I2C lines being > > always high. No other known issues at the moment. =20 >=20 > Hm.... >=20 > >> + {"nvidia,function", TEGRA_PINCONF_PARAM_FUNCTION}, = =20 > > > > FYI, I reduced your patch to only this line plus the one in the > > pinctrl-tegra.h and the problem appears as well. =20 >=20 > I think there is a conflict now, that the pinconf is "stealing" the funct= ion > assignment from the pinmux call. >=20 > It's just a debugprint, I will revert the patch, Luca can investigate and= you Thanks for the quick revert Linus. > can test a new patch then we will merge that. Prathamesh, if you send a new patch it would be great if you can Cc: me so I can test it. Best regards, Luca --=20 Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com