* [PATCH] gpio: pca953x: Convert to use maple tree register cache
@ 2023-09-29 12:24 Mark Brown
2023-10-01 9:24 ` Andy Shevchenko
2023-10-02 6:58 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2023-09-29 12:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko
Cc: linux-gpio, linux-kernel, Mark Brown
The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/gpio/gpio-pca953x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index bdd50a78e414..528ccb59b52a 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -414,7 +414,7 @@ static const struct regmap_config pca953x_i2c_regmap = {
.volatile_reg = pca953x_volatile_register,
.disable_locking = true,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.max_register = 0x7f,
};
@@ -430,7 +430,7 @@ static const struct regmap_config pca953x_ai_i2c_regmap = {
.volatile_reg = pca953x_volatile_register,
.disable_locking = true,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.max_register = 0x7f,
};
---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
change-id: 20230929-gpio-pca953x-maple-b39b99cd90db
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pca953x: Convert to use maple tree register cache
2023-09-29 12:24 [PATCH] gpio: pca953x: Convert to use maple tree register cache Mark Brown
@ 2023-10-01 9:24 ` Andy Shevchenko
2023-10-02 6:58 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-10-01 9:24 UTC (permalink / raw)
To: Mark Brown; +Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel
On Fri, Sep 29, 2023 at 02:24:13PM +0200, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: pca953x: Convert to use maple tree register cache
2023-09-29 12:24 [PATCH] gpio: pca953x: Convert to use maple tree register cache Mark Brown
2023-10-01 9:24 ` Andy Shevchenko
@ 2023-10-02 6:58 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-10-02 6:58 UTC (permalink / raw)
To: Mark Brown; +Cc: Linus Walleij, Andy Shevchenko, linux-gpio, linux-kernel
On Fri, Sep 29, 2023 at 2:24 PM Mark Brown <broonie@kernel.org> wrote:
>
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/gpio/gpio-pca953x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index bdd50a78e414..528ccb59b52a 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -414,7 +414,7 @@ static const struct regmap_config pca953x_i2c_regmap = {
> .volatile_reg = pca953x_volatile_register,
>
> .disable_locking = true,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .max_register = 0x7f,
> };
>
> @@ -430,7 +430,7 @@ static const struct regmap_config pca953x_ai_i2c_regmap = {
> .volatile_reg = pca953x_volatile_register,
>
> .disable_locking = true,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .max_register = 0x7f,
> };
>
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-gpio-pca953x-maple-b39b99cd90db
>
> Best regards,
> --
> Mark Brown <broonie@kernel.org>
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-02 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-29 12:24 [PATCH] gpio: pca953x: Convert to use maple tree register cache Mark Brown
2023-10-01 9:24 ` Andy Shevchenko
2023-10-02 6:58 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).