From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13C6E7735F for ; Sat, 30 Sep 2023 09:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234004AbjI3Jp1 (ORCPT ); Sat, 30 Sep 2023 05:45:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233237AbjI3Jp0 (ORCPT ); Sat, 30 Sep 2023 05:45:26 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37CBBDD; Sat, 30 Sep 2023 02:45:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A4A3C433C8; Sat, 30 Sep 2023 09:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696067123; bh=35Y4iJHA+yWQnYr6BMS/v8x2kCyZKak1olZ7h4RwhS8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u3gL4nunRXW7dTiVTMu0dEo9arEeorI4G1OLEqJ1KTOc3z6kOPDTzyjmCBlYU61+n btC0IHLO/zCfRLv5/b5+i5rQyayKe0L+Lc1FkCpMMJ+YzNAR2+CWOQpZUTybP2uNFB I/j/fP3f85Mzn4BxXEYRp++DT3K3PFekRnniXhjzWFQOS7/i6pk2oeuHsDXIqus7BH hMGn/0ai5UFCm/hgZK4y9xRj0s9Kz1w8WskYi37Eq9WYdPsFGCrM6JN+cbftf8x/Mc DPWlWqrC/zIgjkFXvg5I6LUfMGnfVa6uD2qcoVvK/+UbUfu/nkwhmno9E2oKdjYx0L q40fsAVAs7XXQ== Date: Sat, 30 Sep 2023 10:45:17 +0100 From: Conor Dooley To: Dumitru Ceclan Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org, Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Walle , Andy Shevchenko , Arnd Bergmann , ChiaEn Wu , Niklas Schnelle , Leonard =?iso-8859-1?Q?G=F6hrs?= , Mike Looijmans , Haibo Chen , Hugo Villeneuve , Ceclan Dumitru , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: adc: add AD7173 Message-ID: <20230930-grief-clapper-1c8f4d058969@spud> References: <20230928125443.615006-1-mitrutzceclan@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jOZehTjmQKbhopAK" Content-Disposition: inline In-Reply-To: <20230928125443.615006-1-mitrutzceclan@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --jOZehTjmQKbhopAK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Thu, Sep 28, 2023 at 03:54:42PM +0300, Dumitru Ceclan wrote: > The AD7173 family offer a complete integrated Sigma-Delta ADC solution > which can be used in high precision, low noise single channel applications > or higher speed multiplexed applications. The Sigma-Delta ADC is intended > primarily for measurement of signals close to DC but also delivers > outstanding performance with input bandwidths out to ~10kHz. >=20 > Signed-off-by: Dumitru Ceclan > --- > .../bindings/iio/adc/adi,ad7173.yaml | 139 ++++++++++++++++++ > 1 file changed, 139 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7173.= yaml >=20 > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/= Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > new file mode 100644 > index 000000000000..a0f437297a23 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > @@ -0,0 +1,139 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2023 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7173.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices AD7173 ADC device driver > + > +maintainers: > + - Ceclan Dumitru > + > +description: | > + Bindings for the Analog Devices AD717X ADC's. Datasheets for supported= chips: > + https://www.analog.com/media/en/technical-documentation/data-sheets/= AD7172-2.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/= AD7173-8.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/= AD7175-2.pdf > + https://www.analog.com/media/en/technical-documentation/data-sheets/= AD7176-2.pdf > + > +properties: > + compatible: > + enum: > + - adi,ad7172-2 > + - adi,ad7173-8 > + - adi,ad7175-2 > + - adi,ad7176-2 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + spi-max-frequency: > + maximum: 20000000 > + > + spi-cpol: > + type: boolean > + > + spi-cpha: > + type: boolean > + > + required: > + - compatible > + - reg > + - interrupts > + > +patternProperties: > + "^channel@[0-9a-f]$": > + type: object > + $ref: adc.yaml > + unevaluatedProperties: false > + > + properties: > + reg: > + description: Channel number > + minimum: 0 > + maximum: 15 > + > + diff-channels: > + description: > + Analog input pins These descriptions are redundant AFAICT, since youre just constraining properties defined in adc.yaml. > + items: > + minimum: 0 > + maximum: 31 > + > + adi,bipolar: > + description: Specify if the channel should measure in bipolar mo= de. > + type: boolean You have a ref here to adc.yaml, but do not appear to be making use of "bipolar" property: bipolar: $ref: /schemas/types.yaml#/definitions/flag description: If provided, the channel is to be used in bipolar mode. > + > + required: > + - reg > + - diff-channels > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + spi { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + adc@0 { > + compatible =3D "adi,ad7173-8"; > + reg =3D <0>; > + > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + interrupts =3D <25 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent =3D <&gpio>; > + spi-max-frequency =3D <5000000>; > + > + channel@0 { > + reg =3D <0>; > + adi,bipolar; > + Why the odd newlines? Mostly looks good to me, cheers, Conor. > + diff-channels =3D <0 1>; > + }; > + > + channel@1 { > + reg =3D <1>; > + > + diff-channels =3D <2 3>; > + }; > + > + channel@2 { > + reg =3D <2>; > + adi,bipolar; > + > + diff-channels =3D <4 5>; > + }; > + > + channel@3 { > + reg =3D <3>; > + adi,bipolar; > + > + diff-channels =3D <6 7>; > + }; > + > + channel@4 { > + reg =3D <4>; > + > + diff-channels =3D <8 9>; > + }; > + }; > + }; > --=20 > 2.39.2 >=20 --jOZehTjmQKbhopAK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRfuLQAKCRB4tDGHoIJi 0r+UAP9rtIVQ87EPicIl2kqOobvXvlAxgnYsfHa4HQKS4Np1QQD/ca0SFP9n+6uN XZsNzknuXMWToXtnh8f7OvH8rKeeUgQ= =BSNn -----END PGP SIGNATURE----- --jOZehTjmQKbhopAK--