[PATCH] pinctrl: renesas: rzn1: enable PINMUX

[PATCH] pinctrl: renesas: rzn1: enable PINMUX

[Ralph Siemsen]

Enable pin muxing (eg. programmable function), so that the RZN1 GPIO
pins will be configured as specified by the pinmux in the DTS.

This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS,
however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02
since the rzn1 driver does not call any of the generic pinmux functions.

Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>
---
 drivers/pinctrl/renesas/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/renesas/Kconfig b/drivers/pinctrl/renesas/Kconfig
index 77730dc548ed..0ad8e14ccc52 100644
--- a/drivers/pinctrl/renesas/Kconfig
+++ b/drivers/pinctrl/renesas/Kconfig
@@ -234,6 +234,7 @@ config PINCTRL_RZN1
 	bool "pin control support for RZ/N1"
 	depends on OF
 	depends on ARCH_RZN1 || COMPILE_TEST
+	select PINMUX
 	select GENERIC_PINCONF
 	help
 	  This selects pinctrl driver for Renesas RZ/N1 devices.
-- 
2.25.1

Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX

[Miquel Raynal]

Hi Ralph,

ralph.siemsen@linaro.org wrote on Wed,  4 Oct 2023 16:00:08 -0400:

> Enable pin muxing (eg. programmable function), so that the RZN1 GPIO
> pins will be configured as specified by the pinmux in the DTS.
> 
> This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS,
> however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02
> since the rzn1 driver does not call any of the generic pinmux functions.
> 
> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>

You probably need to point at this commit with a Fixes and possibly Cc
this to stable. Also you should use proper formatting for the commit
(12 digits sha then the text inside ("...")).

With this added:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---
>  drivers/pinctrl/renesas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/renesas/Kconfig b/drivers/pinctrl/renesas/Kconfig
> index 77730dc548ed..0ad8e14ccc52 100644
> --- a/drivers/pinctrl/renesas/Kconfig
> +++ b/drivers/pinctrl/renesas/Kconfig
> @@ -234,6 +234,7 @@ config PINCTRL_RZN1
>  	bool "pin control support for RZ/N1"
>  	depends on OF
>  	depends on ARCH_RZN1 || COMPILE_TEST
> +	select PINMUX
>  	select GENERIC_PINCONF
>  	help
>  	  This selects pinctrl driver for Renesas RZ/N1 devices.


Thanks,
Miquèl

Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX

[Geert Uytterhoeven]

Hi Ralph,

On Wed, Oct 4, 2023 at 10:00 PM Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
> Enable pin muxing (eg. programmable function), so that the RZN1 GPIO
> pins will be configured as specified by the pinmux in the DTS.
>
> This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS,
> however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02

You missed the first character of the commit ID.

> since the rzn1 driver does not call any of the generic pinmux functions.
>
> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>

Fixes: 1308fb4e4eae14e6 ("pinctrl: rzn1: Do not select
GENERIC_PIN{CTRL_GROUPS,MUX_FUNCTIONS}")

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl-fixes-for-v6.6...

> --- a/drivers/pinctrl/renesas/Kconfig
> +++ b/drivers/pinctrl/renesas/Kconfig
> @@ -234,6 +234,7 @@ config PINCTRL_RZN1
>         bool "pin control support for RZ/N1"
>         depends on OF
>         depends on ARCH_RZN1 || COMPILE_TEST
> +       select PINMUX
>         select GENERIC_PINCONF

... with alphabetical sort order restored.
No need to resend.

>         help
>           This selects pinctrl driver for Renesas RZ/N1 devices.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds