linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 14/62] pinctrl: renesas: use new pinctrl GPIO helpers
Date: Wed, 11 Oct 2023 14:07:42 +0200	[thread overview]
Message-ID: <20231011120830.49324-15-brgl@bgdev.pl> (raw)
In-Reply-To: <20231011120830.49324-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Replace the pinctrl helpers taking the global GPIO number as argument
with the improved variants that instead take a pointer to the GPIO chip
and the controller-relative offset.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pinctrl/renesas/gpio.c          | 8 ++++----
 drivers/pinctrl/renesas/pinctrl-rzg2l.c | 4 ++--
 drivers/pinctrl/renesas/pinctrl-rzv2m.c | 4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/renesas/gpio.c b/drivers/pinctrl/renesas/gpio.c
index 5758daf94fe2..e7771a57e6d1 100644
--- a/drivers/pinctrl/renesas/gpio.c
+++ b/drivers/pinctrl/renesas/gpio.c
@@ -135,12 +135,12 @@ static int gpio_pin_request(struct gpio_chip *gc, unsigned offset)
 	if (idx < 0 || pfc->info->pins[idx].enum_id == 0)
 		return -EINVAL;
 
-	return pinctrl_gpio_request(gc->base + offset);
+	return pinctrl_gpio_request_new(gc, offset);
 }
 
 static void gpio_pin_free(struct gpio_chip *gc, unsigned offset)
 {
-	return pinctrl_gpio_free(gc->base + offset);
+	return pinctrl_gpio_free_new(gc, offset);
 }
 
 static void gpio_pin_set_value(struct sh_pfc_chip *chip, unsigned offset,
@@ -164,7 +164,7 @@ static void gpio_pin_set_value(struct sh_pfc_chip *chip, unsigned offset,
 
 static int gpio_pin_direction_input(struct gpio_chip *gc, unsigned offset)
 {
-	return pinctrl_gpio_direction_input(gc->base + offset);
+	return pinctrl_gpio_direction_input_new(gc, offset);
 }
 
 static int gpio_pin_direction_output(struct gpio_chip *gc, unsigned offset,
@@ -172,7 +172,7 @@ static int gpio_pin_direction_output(struct gpio_chip *gc, unsigned offset,
 {
 	gpio_pin_set_value(gpiochip_get_data(gc), offset, value);
 
-	return pinctrl_gpio_direction_output(gc->base + offset);
+	return pinctrl_gpio_direction_output_new(gc, offset);
 }
 
 static int gpio_pin_get(struct gpio_chip *gc, unsigned offset)
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index c7c6d912a975..22d4ab7d228c 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -1056,7 +1056,7 @@ static int rzg2l_gpio_request(struct gpio_chip *chip, unsigned int offset)
 	if (ret)
 		return ret;
 
-	ret = pinctrl_gpio_request(chip->base + offset);
+	ret = pinctrl_gpio_request_new(chip, offset);
 	if (ret)
 		return ret;
 
@@ -1181,7 +1181,7 @@ static void rzg2l_gpio_free(struct gpio_chip *chip, unsigned int offset)
 {
 	unsigned int virq;
 
-	pinctrl_gpio_free(chip->base + offset);
+	pinctrl_gpio_free_new(chip, offset);
 
 	virq = irq_find_mapping(chip->irq.domain, offset);
 	if (virq)
diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
index 52aeafaba4b6..3d29c77a5aad 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
@@ -754,7 +754,7 @@ static int rzv2m_gpio_request(struct gpio_chip *chip, unsigned int offset)
 	u8 bit = RZV2M_PIN_ID_TO_PIN(offset);
 	int ret;
 
-	ret = pinctrl_gpio_request(chip->base + offset);
+	ret = pinctrl_gpio_request_new(chip, offset);
 	if (ret)
 		return ret;
 
@@ -832,7 +832,7 @@ static int rzv2m_gpio_get(struct gpio_chip *chip, unsigned int offset)
 
 static void rzv2m_gpio_free(struct gpio_chip *chip, unsigned int offset)
 {
-	pinctrl_gpio_free(chip->base + offset);
+	pinctrl_gpio_free_new(chip, offset);
 
 	/*
 	 * Set the GPIO as an input to ensure that the next GPIO request won't
-- 
2.39.2


  parent reply	other threads:[~2023-10-11 12:09 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 12:07 [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 01/62] pinctrl: remove unneeded extern specifiers from consumer.h Bartosz Golaszewski
2023-10-11 16:44   ` Andy Shevchenko
2023-10-11 12:07 ` [PATCH v2 02/62] pinctrl: provide new GPIO-to-pinctrl glue helpers Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 03/62] gpiolib: generic: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 04/62] gpio: cdev: use pinctrl_gpio_can_use_line_new() Bartosz Golaszewski
2023-10-11 16:58   ` Andy Shevchenko
2023-10-11 12:07 ` [PATCH v2 05/62] gpio: rcar: use new pinctrl GPIO helpers Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 06/62] gpio: tegra: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 07/62] gpio: em: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 08/62] gpio: aspeed: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 09/62] gpio: mvebu: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 10/62] gpio: pxa: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 11/62] gpio: rockchip: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 12/62] gpio: vf610: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 13/62] pinctrl: nuvoton: " Bartosz Golaszewski
2023-10-11 12:07 ` Bartosz Golaszewski [this message]
2023-10-11 12:07 ` [PATCH v2 15/62] pinctrl: bcm: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 16/62] pinctrl: stm32: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 17/62] pinctrl: spear: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 18/62] pinctrl: starfive: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 19/62] pinctrl: ocelot: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 20/62] pinctrl: rk805: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 21/62] pinctrl: cirrus: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 22/62] pinctrl: mediatek: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 23/62] pinctrl: axp209: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 24/62] pinctrl: vt8500: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 25/62] pinctrl: cy8c95x0: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 26/62] pinctrl: as3722: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 27/62] pinctrl: ingenic: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 28/62] pinctrl: intel: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 29/62] pinctrl: st: " Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 30/62] pinctrl: remove pinctrl_gpio_can_use_line() Bartosz Golaszewski
2023-10-11 12:07 ` [PATCH v2 31/62] pinctrl: remove pinctrl_gpio_request() Bartosz Golaszewski
2023-10-11 16:54   ` Andy Shevchenko
2023-10-12 19:43     ` Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 32/62] pinctrl: remove pinctrl_gpio_free() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 33/62] pinctrl: remove pinctrl_gpio_direction_input() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 34/62] pinctrl: remove pinctrl_gpio_direction_output() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 35/62] pinctrl: remove pinctrl_gpio_set_config() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 36/62] treewide: rename pinctrl_gpio_can_use_line_new() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 37/62] treewide: rename pinctrl_gpio_request_new() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 38/62] treewide: rename pinctrl_gpio_free_new() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 39/62] treewide: rename pinctrl_gpio_direction_input_new() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 40/62] treewide: rename pinctrl_gpio_direction_output_new() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 41/62] treewide: rename pinctrl_gpio_set_config_new() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 42/62] pinctrl: change the signature of pinctrl_gpio_direction() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 43/62] pinctrl: change the signature of pinctrl_get_device_gpio_range() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 44/62] pinctrl: change the signature of pinctrl_match_gpio_range() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 45/62] pinctrl: change the signature of gpio_to_pin() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 46/62] pinctrl: change the signature of pinctrl_ready_for_gpio_range() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 47/62] pinctrl: intel: drop the wrappers around pinctrl_gpio_direction_input() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 48/62] pinctrl: st: drop the wrapper " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 49/62] pinctrl: ingenic: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 50/62] pinctrl: as3722: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 51/62] pinctrl: cy8c95x0: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 52/62] pinctrl: vt8500: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 53/62] pinctrl: axp209: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 54/62] pinctrl: rk805: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 55/62] pinctrl: mediatek: drop the wrappers " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 56/62] pinctrl: cirrus: drop the wrapper " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 57/62] pinctrl: ocelot: " Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 58/62] pinctrl: starfive: drop wrappers around pinctrl_gpio_request/free() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 59/62] pinctrl: stm32: drop wrappers around pinctrl_gpio_free/input() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 60/62] pinctrl: nuvoton: drop wrappers around pinctrl_gpio_request/free() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 61/62] pinctrl: em: drop the wrapper around pinctrl_gpio_request() Bartosz Golaszewski
2023-10-11 12:08 ` [PATCH v2 62/62] pinctrl: tegra: " Bartosz Golaszewski
2023-10-11 17:04 ` [PATCH v2 00/62] pinctrl: don't use GPIOLIB global numberspace in helpers Andy Shevchenko
2023-10-12  7:08 ` Linus Walleij
2023-10-12 13:23   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011120830.49324-15-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).