From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hans de Goede <hdegoede@redhat.com>,
Ferry Toth <ftoth@exalondelft.nl>
Subject: [PATCH v1 1/3] gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data()
Date: Thu, 19 Oct 2023 20:34:55 +0300 [thread overview]
Message-ID: <20231019173457.2445119-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231019173457.2445119-1-andriy.shevchenko@linux.intel.com>
When refactoring the acpi_get_gpiod_from_data() the change missed
cleaning up the variable on stack. Add missing memset().
Reported-by: Ferry Toth <ftoth@exalondelft.nl>
Fixes: 16ba046e86e9 ("gpiolib: acpi: teach acpi_find_gpio() to handle data-only nodes")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpiolib-acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index fbda452fb4d6..51e41676de0b 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -951,6 +951,7 @@ static struct gpio_desc *acpi_get_gpiod_from_data(struct fwnode_handle *fwnode,
if (!propname)
return ERR_PTR(-EINVAL);
+ memset(&lookup, 0, sizeof(lookup));
lookup.index = index;
ret = acpi_gpio_property_lookup(fwnode, propname, index, &lookup);
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-10-19 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 17:34 [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework Andy Shevchenko
2023-10-19 17:34 ` Andy Shevchenko [this message]
2023-10-19 19:20 ` [PATCH v1 1/3] gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data() Dmitry Torokhov
2023-10-20 9:25 ` Bartosz Golaszewski
2023-10-19 17:34 ` [PATCH v1 2/3] gpiolib: Fix debug messaging in gpiod_find_and_request() Andy Shevchenko
2023-10-19 19:21 ` Dmitry Torokhov
2023-11-14 15:29 ` Andy Shevchenko
2023-11-14 21:18 ` Dmitry Torokhov
2023-11-15 1:37 ` andy.shevchenko
2023-11-15 14:57 ` Dmitry Torokhov
2024-03-20 15:05 ` Andy Shevchenko
2023-11-14 20:26 ` Linus Walleij
2023-10-19 17:34 ` [PATCH v1 3/3] gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusing Andy Shevchenko
2023-11-14 20:29 ` Linus Walleij
2023-10-20 11:50 ` [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework Ferry Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231019173457.2445119-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=ftoth@exalondelft.nl \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).