From: Linhua Xu <Linhua.xu@unisoc.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
lh xu <xulh0829@gmail.com>, Linhua Xu <Linhua.Xu@unisoc.com>,
Zhirong Qiu <zhirong.qiu@unisoc.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Subject: [PATCH V3 1/6] pinctrl: sprd: Modify pull-up parameters
Date: Fri, 27 Oct 2023 15:14:21 +0800 [thread overview]
Message-ID: <20231027071426.17724-2-Linhua.xu@unisoc.com> (raw)
In-Reply-To: <20231027071426.17724-1-Linhua.xu@unisoc.com>
From: Linhua Xu <Linhua.Xu@unisoc.com>
For UNISOC pin controller, there are three different configurations of
pull-up drive current. Modify the 20K pull-up resistor configuration and
add the 1.8K pull-up resistor configuration.
Fixes:<1fb4b907e808> ("pinctrl: sprd: Add Spreadtrum pin control driver")
Signed-off-by: Linhua Xu <Linhua.Xu@unisoc.com>
---
drivers/pinctrl/sprd/pinctrl-sprd.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index ca9659f4e4b1..74d8f8c3b9b6 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -71,7 +71,8 @@
#define SLEEP_PULL_UP_MASK 0x1
#define SLEEP_PULL_UP_SHIFT 3
-#define PULL_UP_4_7K (BIT(12) | BIT(7))
+#define PULL_UP_1_8K (BIT(12) | BIT(7))
+#define PULL_UP_4_7K BIT(12)
#define PULL_UP_20K BIT(7)
#define PULL_UP_MASK 0x21
#define PULL_UP_SHIFT 7
@@ -497,7 +498,7 @@ static int sprd_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin_id,
break;
case PIN_CONFIG_BIAS_DISABLE:
if ((reg & (SLEEP_PULL_DOWN | SLEEP_PULL_UP)) ||
- (reg & (PULL_DOWN | PULL_UP_4_7K | PULL_UP_20K)))
+ (reg & (PULL_DOWN | PULL_UP_4_7K | PULL_UP_20K | PULL_UP_1_8K)))
return -EINVAL;
arg = 1;
@@ -699,6 +700,8 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
val |= PULL_UP_20K;
else if (arg == 4700)
val |= PULL_UP_4_7K;
+ else if (arg == 1800)
+ val |= PULL_UP_1_8K;
mask = PULL_UP_MASK;
shift = PULL_UP_SHIFT;
@@ -711,7 +714,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
} else {
val = shift = 0;
mask = PULL_DOWN | PULL_UP_20K |
- PULL_UP_4_7K;
+ PULL_UP_4_7K | PULL_UP_1_8K;
}
break;
case PIN_CONFIG_SLEEP_HARDWARE_STATE:
--
2.17.1
next prev parent reply other threads:[~2023-10-27 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 7:14 [PATCH V3 0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver Linhua Xu
2023-10-27 7:14 ` Linhua Xu [this message]
2023-10-27 11:29 ` [PATCH V3 1/6] pinctrl: sprd: Modify pull-up parameters Andy Shevchenko
2023-10-27 7:14 ` [PATCH V3 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition Linhua Xu
2023-10-27 11:32 ` Andy Shevchenko
2023-10-27 7:14 ` [PATCH V3 3/6] pinctrl: sprd: Move common and misc offset parameters to private data Linhua Xu
2023-10-27 11:24 ` Andy Shevchenko
2023-10-27 7:14 ` [PATCH V3 4/6] pinctrl: sprd: Increase the range of register values Linhua Xu
2023-10-27 11:39 ` kernel test robot
2023-10-27 7:14 ` [PATCH V3 5/6] pinctrl: sprd: Add pinctrl support for UMS512 Linhua Xu
2023-10-27 11:40 ` Andy Shevchenko
2023-10-27 7:14 ` [PATCH V3 6/6] pinctrl: sprd: Add pinctrl support for UMS9621 Linhua Xu
2023-10-27 11:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231027071426.17724-2-Linhua.xu@unisoc.com \
--to=linhua.xu@unisoc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=xulh0829@gmail.com \
--cc=zhang.lyra@gmail.com \
--cc=zhirong.qiu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).