From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Subject: [PATCH v3 17/17] pinctrl: intel: Make PM ops functions static
Date: Mon, 30 Oct 2023 14:07:34 +0200 [thread overview]
Message-ID: <20231030120734.2831419-18-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231030120734.2831419-1-andriy.shevchenko@linux.intel.com>
No more users outside of the main module.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 6 ++----
drivers/pinctrl/intel/pinctrl-intel.h | 9 ---------
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 9fbdc7bfa65c..f1d8f7e0d9b7 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1727,7 +1727,7 @@ static bool intel_pinctrl_should_save(struct intel_pinctrl *pctrl, unsigned int
return false;
}
-int intel_pinctrl_suspend_noirq(struct device *dev)
+static int intel_pinctrl_suspend_noirq(struct device *dev)
{
struct intel_pinctrl *pctrl = dev_get_drvdata(dev);
struct intel_community_context *communities;
@@ -1770,7 +1770,6 @@ int intel_pinctrl_suspend_noirq(struct device *dev)
return 0;
}
-EXPORT_SYMBOL_GPL(intel_pinctrl_suspend_noirq);
static bool intel_gpio_update_reg(void __iomem *reg, u32 mask, u32 value)
{
@@ -1837,7 +1836,7 @@ static void intel_restore_padcfg(struct intel_pinctrl *pctrl, unsigned int pin,
dev_dbg(dev, "restored pin %u padcfg%u %#08x\n", pin, n, readl(padcfg));
}
-int intel_pinctrl_resume_noirq(struct device *dev)
+static int intel_pinctrl_resume_noirq(struct device *dev)
{
struct intel_pinctrl *pctrl = dev_get_drvdata(dev);
const struct intel_community_context *communities;
@@ -1881,7 +1880,6 @@ int intel_pinctrl_resume_noirq(struct device *dev)
return 0;
}
-EXPORT_SYMBOL_GPL(intel_pinctrl_resume_noirq);
EXPORT_NS_GPL_DEV_PM_OPS(intel_pinctrl_pm_ops, PINCTRL_INTEL) = {
NOIRQ_SYSTEM_SLEEP_PM_OPS(intel_pinctrl_suspend_noirq, intel_pinctrl_resume_noirq)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.h b/drivers/pinctrl/intel/pinctrl-intel.h
index d3f511f97ed9..e7d911a65584 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.h
+++ b/drivers/pinctrl/intel/pinctrl-intel.h
@@ -255,15 +255,6 @@ struct intel_pinctrl {
int intel_pinctrl_probe_by_hid(struct platform_device *pdev);
int intel_pinctrl_probe_by_uid(struct platform_device *pdev);
-int intel_pinctrl_suspend_noirq(struct device *dev);
-int intel_pinctrl_resume_noirq(struct device *dev);
-
-#define INTEL_PINCTRL_PM_OPS(_name) \
-const struct dev_pm_ops _name = { \
- SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(intel_pinctrl_suspend_noirq, \
- intel_pinctrl_resume_noirq) \
-}
-
extern const struct dev_pm_ops intel_pinctrl_pm_ops;
struct intel_community *intel_get_community(struct intel_pinctrl *pctrl, unsigned int pin);
--
2.40.0.1.gaa8946217a0b
next prev parent reply other threads:[~2023-10-30 12:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 12:07 [PATCH v3 00/17] pinctrl: intel: Use NOIRQ PM helper Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 01/17] pinctrl: intel: Provide Intel pin control wide PM ops structure Andy Shevchenko
2023-10-30 19:41 ` Jonathan Cameron
2023-10-30 19:43 ` Jonathan Cameron
2023-10-30 19:56 ` Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 02/17] pinctrl: alderlake: Switch to use Intel pin control PM ops Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 03/17] pinctrl: broxton: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 04/17] pinctrl: cannonlake: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 05/17] pinctrl: cedarfork: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 06/17] pinctrl: denverton: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 07/17] pinctrl: elkhartlake: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 08/17] pinctrl: emmitsburg: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 09/17] pinctrl: geminilake: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 10/17] pinctrl: icelake: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 11/17] pinctrl: jasperlake: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 12/17] pinctrl: lakefield: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 13/17] pinctrl: lewisburg: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 14/17] pinctrl: meteorlake: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 15/17] pinctrl: sunrisepoint: " Andy Shevchenko
2023-10-30 12:07 ` [PATCH v3 16/17] pinctrl: tigerlake: " Andy Shevchenko
2023-10-30 12:07 ` Andy Shevchenko [this message]
2023-11-02 12:57 ` [PATCH v3 00/17] pinctrl: intel: Use NOIRQ PM helper Linus Walleij
2023-11-10 6:14 ` Mika Westerberg
2023-11-13 11:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030120734.2831419-18-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).