From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v1 1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set()
Date: Wed, 22 Nov 2023 19:50:36 +0200 [thread overview]
Message-ID: <20231122175039.2289945-1-andriy.shevchenko@linux.intel.com> (raw)
When unpacked, the config value is split to two of different types.
Fix the types accordingly.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index 3cd0798ee631..f1af21dbd5fb 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -918,13 +918,14 @@ static int byt_pin_config_set(struct pinctrl_dev *pctl_dev,
unsigned int num_configs)
{
struct intel_pinctrl *vg = pinctrl_dev_get_drvdata(pctl_dev);
- unsigned int param, arg;
void __iomem *conf_reg = byt_gpio_reg(vg, offset, BYT_CONF0_REG);
void __iomem *val_reg = byt_gpio_reg(vg, offset, BYT_VAL_REG);
void __iomem *db_reg = byt_gpio_reg(vg, offset, BYT_DEBOUNCE_REG);
u32 conf, val, db_pulse, debounce;
+ enum pin_config_param param;
unsigned long flags;
int i, ret = 0;
+ u32 arg;
raw_spin_lock_irqsave(&byt_lock, flags);
--
2.43.0.rc1.1.gbec44491f096
next reply other threads:[~2023-11-22 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 17:50 Andy Shevchenko [this message]
2023-11-22 17:50 ` [PATCH v1 2/4] pinctrl: baytrail: Factor out byt_gpio_force_input_mode() Andy Shevchenko
2023-11-23 14:53 ` Linus Walleij
2023-11-22 17:50 ` [PATCH v1 3/4] pinctrl: baytrail: Move default strength assignment to a switch-case Andy Shevchenko
2023-11-23 14:54 ` Linus Walleij
2023-11-24 5:31 ` Mika Westerberg
2023-11-22 17:50 ` [PATCH v1 4/4] pinctrl: baytrail: Simplify code with cleanup helpers Andy Shevchenko
2023-11-23 14:54 ` Linus Walleij
2023-11-24 5:33 ` [PATCH v1 1/4] pinctrl: baytrail: Fix types of config value in byt_pin_config_set() Mika Westerberg
2023-11-24 11:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122175039.2289945-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).