linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
	"Jianlong Huang" <jianlong.huang@starfivetech.com>,
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Sean Wang <sean.wang@kernel.org>,
	Paul Cercueil <paul@crapouillou.net>,
	Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Hal Feng <hal.feng@starfivetech.com>
Subject: [PATCH v4 04/23] pinctrl: equilibrium: Use temporary variable to hold pins
Date: Wed, 29 Nov 2023 18:06:27 +0200	[thread overview]
Message-ID: <20231129161459.1002323-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com>

The pins are allocated from the heap, but in order to pass
them as constant object, we need to use non-constant pointer.
Achieve this by using a temporary variable.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/pinctrl-equilibrium.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-equilibrium.c b/drivers/pinctrl/pinctrl-equilibrium.c
index 54755b583d3f..fd59cfdeefac 100644
--- a/drivers/pinctrl/pinctrl-equilibrium.c
+++ b/drivers/pinctrl/pinctrl-equilibrium.c
@@ -704,7 +704,7 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata)
 {
 	struct device *dev = drvdata->dev;
 	struct device_node *node = dev->of_node;
-	unsigned int *pinmux, pin_id, pinmux_id;
+	unsigned int *pins, *pinmux, pin_id, pinmux_id;
 	struct group_desc group;
 	struct device_node *np;
 	struct property *prop;
@@ -723,15 +723,14 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata)
 		}
 		group.num_pins = err;
 		group.name = prop->value;
-		group.pins = devm_kcalloc(dev, group.num_pins,
-					  sizeof(*(group.pins)), GFP_KERNEL);
-		if (!group.pins) {
+		pins = devm_kcalloc(dev, group.num_pins, sizeof(*pins), GFP_KERNEL);
+		if (!pins) {
 			of_node_put(np);
 			return -ENOMEM;
 		}
+		group.pins = pins;
 
-		pinmux = devm_kcalloc(dev, group.num_pins, sizeof(*pinmux),
-				      GFP_KERNEL);
+		pinmux = devm_kcalloc(dev, group.num_pins, sizeof(*pinmux), GFP_KERNEL);
 		if (!pinmux) {
 			of_node_put(np);
 			return -ENOMEM;
@@ -750,7 +749,7 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata)
 				of_node_put(np);
 				return -EINVAL;
 			}
-			group.pins[j] = pin_id;
+			pins[j] = pin_id;
 			if (of_property_read_u32_index(np, "pinmux", j, &pinmux_id)) {
 				dev_err(dev, "Group %s: Read intel pinmux id failed\n",
 					group.name);
-- 
2.43.0.rc1.1.gbec44491f096


  parent reply	other threads:[~2023-11-29 16:15 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 16:06 [PATCH v4 00/23] pinctrl: Convert struct group_desc to use struct pingroup Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 01/23] pinctrl: qcom: lpass-lpi: Replace kernel.h with what is being used Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 02/23] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 03/23] pinctrl: equilibrium: Unshadow error code of of_property_count_u32_elems() Andy Shevchenko
2023-11-29 16:06 ` Andy Shevchenko [this message]
2023-11-29 16:06 ` [PATCH v4 05/23] pinctrl: imx: Use temporary variable to hold pins Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 06/23] pinctrl: core: Make pins const unsigned int pointer in struct group_desc Andy Shevchenko
2023-11-30 10:34   ` Geert Uytterhoeven
2023-11-29 16:06 ` [PATCH v4 07/23] pinctrl: equilibrium: Convert to use struct pingroup Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 08/23] pinctrl: keembay: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 09/23] pinctrl: nuvoton: Convert to use struct pingroup and PINCTRL_PINGROUP() Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 10/23] pinctrl: core: Add a convenient define PINCTRL_GROUP_DESC() Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 11/23] pinctrl: ingenic: Make use of PINCTRL_GROUP_DESC() Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 12/23] pinctrl: mediatek: " Andy Shevchenko
     [not found]   ` <CGME20231204114039eucas1p29c6f8a162191e58ff658d3a1c44429bf@eucas1p2.samsung.com>
2023-12-04 11:40     ` Marek Szyprowski
2023-12-04 13:10       ` Andy Shevchenko
2023-12-04 13:18         ` Krzysztof Kozlowski
2023-12-04 13:20           ` Krzysztof Kozlowski
2023-12-04 13:19         ` Geert Uytterhoeven
2023-12-04 13:32           ` Andy Shevchenko
2023-12-04 13:39             ` Geert Uytterhoeven
2023-12-04 16:02               ` Andy Shevchenko
     [not found]   ` <CGME20231204114016eucas1p2689bcb5a8e754555ae5821ac6cabe7e9@eucas1p2.samsung.com>
     [not found]     ` <6161d2f2-f112-4a53-8e6b-0956c0fa2cbe@samsung.com>
2023-12-04 12:38       ` Krzysztof Kozlowski
2023-11-29 16:06 ` [PATCH v4 13/23] pinctrl: core: Embed struct pingroup into struct group_desc Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 14/23] pinctrl: bcm: Convert to use grp member Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 15/23] pinctrl: equilibrium: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 16/23] pinctrl: imx: " Andy Shevchenko
2023-11-29 16:36   ` Fabio Estevam
2023-11-29 17:00     ` Andy Shevchenko
2023-11-29 17:08       ` Fabio Estevam
2023-11-29 17:17         ` Andy Shevchenko
2023-11-29 21:41           ` Linus Walleij
2023-11-30 16:48             ` Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 17/23] pinctrl: ingenic: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 18/23] pinctrl: keembay: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 19/23] pinctrl: mediatek: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 20/23] pinctrl: renesas: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 21/23] pinctrl: starfive: " Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 22/23] pinctrl: core: Remove unused members from struct group_desc Andy Shevchenko
2023-11-29 16:06 ` [PATCH v4 23/23] pinctrl: Convert unsigned to unsigned int Andy Shevchenko
2023-12-01 14:05 ` [PATCH v4 00/23] pinctrl: Convert struct group_desc to use struct pingroup Linus Walleij
2023-12-01 14:19   ` Andy Shevchenko
2023-12-04  7:49   ` Krzysztof Kozlowski
2023-12-04  7:51     ` Krzysztof Kozlowski
2023-12-04 14:35     ` Linus Walleij
2023-12-04 14:38 ` Linus Walleij
2023-12-04 14:49   ` Andy Shevchenko
2023-12-07  9:50     ` Linus Walleij
2023-12-07 13:14       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231129161459.1002323-5-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=agross@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=andersson@kernel.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=hal.feng@starfivetech.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=jianlong.huang@starfivetech.com \
    --cc=kernel@esmil.dk \
    --cc=kernel@pengutronix.de \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lakshmi.sowjanya.d@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=openbmc@lists.ozlabs.org \
    --cc=paul@crapouillou.net \
    --cc=ping.bai@nxp.com \
    --cc=rjui@broadcom.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=sean.wang@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).