From: Lee Jones <lee@kernel.org>
To: "GaryWang 汪之逸" <GaryWang@aaeon.com.tw>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"larry.lai" <larry.lai@yunjingtech.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"musa.lin@yunjingtech.com" <musa.lin@yunjingtech.com>,
"jack.chang@yunjingtech.com" <jack.chang@yunjingtech.com>,
"noah.hung@yunjingtech.com" <noah.hung@yunjingtech.com>
Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA
Date: Thu, 30 Nov 2023 11:21:30 +0000 [thread overview]
Message-ID: <20231130112130.GH1470173@google.com> (raw)
In-Reply-To: <SI2PR02MB568243153C4D4D7B636D2754EE82A@SI2PR02MB5682.apcprd02.prod.outlook.com>
On Thu, 30 Nov 2023, GaryWang 汪之逸 wrote:
> All,
> Reply again to plain text format & line-warp and trim agree part as Jones's suggestion,
> please let me know if there are still having format issue.
> please kindly to check our comments with ">>" beginning.
This is still incorrect.
Please fix your mail client, or use a different one.
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Tuesday, November 14, 2023 10:19 PM
> To: larry.lai <larry.lai@yunjingtech.com>
> Cc: lee@kernel.org; linus.walleij@linaro.org; pavel@ucw.cz; linux-kernel@vger.kernel.org; linux-gpio@vger.kernel.org; linux-leds@vger.kernel.org; GaryWang 汪之逸 <GaryWang@aaeon.com.tw>; musa.lin@yunjingtech.com; jack.chang@yunjingtech.com; noah.hung@yunjingtech.com
> Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA
Why is your client putting headers in the body?
> On Tue, Oct 31, 2023 at 09:51:18AM +0800, larry.lai wrote:
> > The UP Squared board
> > <http://www.upboard.com/> implements certain features (pin control) through an on-board FPGA.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Gary Wang <garywang@aaeon.com.tw>
> > Signed-off-by: larry.lai <larry.lai@yunjingtech.com>
>
>
>
> > +#include "intel/pinctrl-intel.h"
>
> I do not think it's correct use of the header.
> >> see below
No, this should look like this:
> <Thing you're replying to here>
[Your response here]
Please fix the client to quote properly and drop the confusing ">>" stuff.
> ...
Make snips clearer please, either:
[...]
Or:
[SNIP]
[...]
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-11-30 11:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 1:51 [PATCH V7 0/3] Add support control UP board CPLD/FPGA pin control larry.lai
2023-10-31 1:51 ` [PATCH V7 1/3] mfd: Add support for UP board CPLD/FPGA larry.lai
2023-11-14 14:11 ` Andy Shevchenko
2023-11-24 9:11 ` GaryWang 汪之逸
2023-11-27 9:37 ` Lee Jones
2023-11-30 6:19 ` GaryWang 汪之逸
2023-12-01 8:19 ` larry
2023-10-31 1:51 ` [PATCH V7 2/3] pinctrl: Add support pin control " larry.lai
2023-11-01 10:42 ` Krzysztof Kozlowski
2023-11-13 14:15 ` Linus Walleij
2023-11-13 16:35 ` Andy Shevchenko
2023-11-14 14:18 ` Andy Shevchenko
2023-11-24 9:11 ` GaryWang 汪之逸
2023-11-30 6:19 ` GaryWang 汪之逸
2023-11-30 11:21 ` Lee Jones [this message]
2023-12-01 8:40 ` larry
2023-10-31 1:51 ` [PATCH V7 3/3] leds: Add support for UP board CPLD onboard LEDS larry.lai
2023-11-01 10:44 ` Krzysztof Kozlowski
2023-11-14 14:20 ` [PATCH V7 0/3] Add support control UP board CPLD/FPGA pin control Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130112130.GH1470173@google.com \
--to=lee@kernel.org \
--cc=GaryWang@aaeon.com.tw \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jack.chang@yunjingtech.com \
--cc=larry.lai@yunjingtech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=musa.lin@yunjingtech.com \
--cc=noah.hung@yunjingtech.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).