From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDCE318E01; Thu, 30 Nov 2023 11:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N0yL/cRS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F20EC433C7; Thu, 30 Nov 2023 11:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701343295; bh=NAX56mGLpXw5uJMlSh9lqnmNXCJ2hfJhtUZAindNF3E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N0yL/cRSIVQpcl6fVvr8mxdMcZW+E5Dg42fs2g3tr5ZHCOCAtKiZpDjEtAg9oHw5L f8Viz58ff9taLyf8Rv0ZYqCv3mESK/dKzlp9mfD0xy9dG7P4TEf/q4usMU8oTYXYhf Ta0yKvmySjPyZfhHRbRGm2PQpklbO+AJ26Q36vmeqhYBPhct8+iBd+Qw3Sis6bhaGS eEsiiVSce8IY1DjQHft76URmCCw49tPdAMzr0BTweoaaKAcKvgrqSiNqQJTYsxs7Ko jC7nS8GxJRV3jRb1n1eF4lND8W5cNzDH/4510btFuu7w5KRxiSvXbn3dpoe4pgukwG SY3BvtCjonAyg== Date: Thu, 30 Nov 2023 11:21:30 +0000 From: Lee Jones To: GaryWang =?utf-8?B?5rGq5LmL6YC4?= Cc: Andy Shevchenko , "larry.lai" , "linus.walleij@linaro.org" , "pavel@ucw.cz" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-leds@vger.kernel.org" , "musa.lin@yunjingtech.com" , "jack.chang@yunjingtech.com" , "noah.hung@yunjingtech.com" Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA Message-ID: <20231130112130.GH1470173@google.com> References: <20231031015119.29756-1-larry.lai@yunjingtech.com> <20231031015119.29756-3-larry.lai@yunjingtech.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, 30 Nov 2023, GaryWang 汪之逸 wrote: > All, > Reply again to plain text format & line-warp and trim agree part as Jones's suggestion, > please let me know if there are still having format issue. > please kindly to check our comments with ">>" beginning. This is still incorrect. Please fix your mail client, or use a different one. > -----Original Message----- > From: Andy Shevchenko > Sent: Tuesday, November 14, 2023 10:19 PM > To: larry.lai > Cc: lee@kernel.org; linus.walleij@linaro.org; pavel@ucw.cz; linux-kernel@vger.kernel.org; linux-gpio@vger.kernel.org; linux-leds@vger.kernel.org; GaryWang 汪之逸 ; musa.lin@yunjingtech.com; jack.chang@yunjingtech.com; noah.hung@yunjingtech.com > Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA Why is your client putting headers in the body? > On Tue, Oct 31, 2023 at 09:51:18AM +0800, larry.lai wrote: > > The UP Squared board > > implements certain features (pin control) through an on-board FPGA. > > > > Reported-by: kernel test robot > > Signed-off-by: Gary Wang > > Signed-off-by: larry.lai > > > > > +#include "intel/pinctrl-intel.h" > > I do not think it's correct use of the header. > >> see below No, this should look like this: > [Your response here] Please fix the client to quote properly and drop the confusing ">>" stuff. > ... Make snips clearer please, either: [...] Or: [SNIP] [...] -- Lee Jones [李琼斯]