From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Ceclan Dumitru" <mitrutzceclan@gmail.com>,
linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Arnd Bergmann" <arnd@arndb.de>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver
Date: Wed, 6 Dec 2023 17:48:17 +0000 [thread overview]
Message-ID: <20231206174817.2bc4f39f@jic23-huawei> (raw)
In-Reply-To: <ZW9bVDLZl4-QLIbg@smile.fi.intel.com>
On Tue, 5 Dec 2023 19:18:12 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, Dec 05, 2023 at 06:12:18PM +0200, Ceclan Dumitru wrote:
> > On 12/5/23 17:28, Andy Shevchenko wrote:
> > >> + ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF];
> > >> +
> > >> + fwnode_property_read_string(child, "adi,reference-select",
> > >> + &ref_label);
> > >> + ref_sel = match_string(ad7173_ref_sel_str,
> > >> + ARRAY_SIZE(ad7173_ref_sel_str), ref_label);
> > >> + if (ref_sel < 0) {
> > > Can we use fwnode_property_match_property_string()?
> >
> > fwnode_property_match_string() searches a given string in a device-tree
> > string array and returns the index. I do not think that this function
> > fits here as the DT attribute is a single string.
>
> I'm not talking about that. I mentioned different API call.
>
> /**
> * fwnode_property_match_property_string - find a property string value in an array and return index
> * @fwnode: Firmware node to get the property of
> * @propname: Name of the property holding the string value
> * @array: String array to search in
> * @n: Size of the @array
> *
> * Find a property string value in a given @array and if it is found return
> * the index back.
> *
> * Return: index, starting from %0, if the string value was found in the @array (success),
> * %-ENOENT when the string value was not found in the @array,
> * %-EINVAL if given arguments are not valid,
> * %-ENODATA if the property does not have a value,
> * %-EPROTO or %-EILSEQ if the property is not a string,
> * %-ENXIO if no suitable firmware interface is present.
> */
>
Which is in the togreg branch of iio.git (was a patch from Andy that I've queued up)
Jonathan
next prev parent reply other threads:[~2023-12-06 17:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 13:42 [PATCH v7 1/2] dt-bindings: adc: add AD7173 Dumitru Ceclan
2023-12-05 13:42 ` [PATCH v7 2/2] iio: adc: ad7173: add AD7173 driver Dumitru Ceclan
2023-12-05 13:49 ` Ceclan Dumitru
2023-12-05 15:28 ` Andy Shevchenko
2023-12-05 15:59 ` Andy Shevchenko
2023-12-05 16:12 ` Ceclan Dumitru
2023-12-05 17:18 ` Andy Shevchenko
[not found] ` <e03e40b55f834d5cafb67bf728599688@analog.com>
2023-12-06 17:31 ` Ceclan Dumitru
2023-12-06 17:48 ` Jonathan Cameron [this message]
2023-12-07 1:22 ` kernel test robot
2023-12-05 13:50 ` [PATCH v7 1/2] dt-bindings: adc: add AD7173 Ceclan Dumitru
2023-12-05 15:16 ` Rob Herring
2023-12-05 16:25 ` Conor Dooley
2023-12-05 16:33 ` Ceclan Dumitru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206174817.2bc4f39f@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dumitru.ceclan@analog.com \
--cc=haibo.chen@nxp.com \
--cc=hvilleneuve@dimonoff.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mike.looijmans@topic.nl \
--cc=mitrutzceclan@gmail.com \
--cc=robh+dt@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).