From: Kent Gibson <warthog618@gmail.com>
To: "J.A. Bezemer" <j.a.bezemer@opensourcepartners.nl>
Cc: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Subject: Re: [libgpiod][PATCH] line-config.c: Fix library enum used for kernel flags bitfield
Date: Sun, 31 Dec 2023 10:02:28 +0800 [thread overview]
Message-ID: <20231231020228.GA8143@rigel> (raw)
In-Reply-To: <20231231015727.GA3304@rigel>
On Sun, Dec 31, 2023 at 09:57:27AM +0800, Kent Gibson wrote:
> On Sat, Dec 30, 2023 at 01:48:53PM +0100, J.A. Bezemer wrote:
> > Library enum was used to sanitize kernel flags.
> >
>
> Rephrase to make imperative and better describe what is being fixed.
> e.g.
>
> "Fix deselection of output direction when edge detection is selected in
> make_kernel_flags(). Use correct flag to perform deselection rather than
> a library enum."
>
While I think if it, that also applies to the subject line.
And that should probably begin with "core:" as it indicates the section
of the code tree being modified.
Sorry - more nitpicking.
Cheers,
Kent.
next prev parent reply other threads:[~2023-12-31 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-30 12:48 [libgpiod][PATCH] line-config.c: Fix library enum used for kernel flags bitfield J.A. Bezemer
2023-12-31 1:57 ` Kent Gibson
2023-12-31 2:02 ` Kent Gibson [this message]
2024-01-02 14:50 ` J.A. Bezemer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231231020228.GA8143@rigel \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=j.a.bezemer@opensourcepartners.nl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).