From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [176.9.242.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 000C117C60 for ; Mon, 15 Jan 2024 16:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 560E2100DCEC5; Mon, 15 Jan 2024 17:35:55 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id E988740EC3; Mon, 15 Jan 2024 17:35:54 +0100 (CET) Date: Mon, 15 Jan 2024 17:35:54 +0100 From: Lukas Wunner To: Bartosz Golaszewski Cc: Linus Walleij , Andy Shevchenko , linux-gpio@vger.kernel.org Subject: Re: [PATCH] gpiolib: Fix scope-based gpio_device refcounting Message-ID: <20240115163554.GA4205@wunner.de> References: Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Mon, Jan 15, 2024 at 05:09:05PM +0100, Bartosz Golaszewski wrote: > On Mon, Jan 15, 2024 at 4:05PM Lukas Wunner wrote: > > While at it drop a superfluous trailing semicolon. > > While not strictly needed here - I think it's better for readability > to have a semicolon following every statement. Any reasons for why > dropping it is better? I looked at all the DEFINE_FREE definitions in Linus' current master and this appears to be the only one with the extraneous semicolon, so one reason is consistency. Another the avoidance of the illusion that this is a proper C statement. It's basically an empty statement so it doesn't hurt but it doesn't provide any value either. Thanks, Lukas