From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Phil Howard <phil@gadgetoid.com>,
Erik Schilling <erik.schilling@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH v2] README: mention the Linux 5.10 requirement for libgpiod v2
Date: Tue, 16 Jan 2024 18:08:34 +0800 [thread overview]
Message-ID: <20240116100834.GA3474@rigel> (raw)
In-Reply-To: <20240116094057.10533-1-brgl@bgdev.pl>
On Tue, Jan 16, 2024 at 10:40:57AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Major version 2 of libgpiod requires linux kernel uAPI v2 to be available.
> This was released in Linux 5.10 so mention it in the README.
>
> Suggested-by: Kent Gibson <warthog618@gmail.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> v1 -> v2:
> - reword as suggested by Kent
>
> README | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/README b/README
> index 632aab3..6063f43 100644
> --- a/README
> +++ b/README
> @@ -8,8 +8,9 @@ libgpiod
> character device (gpiod stands for GPIO device)
>
> Since linux 4.8 the GPIO sysfs interface is deprecated. User space should use
> -the character device instead. This library encapsulates the ioctl calls and
> -data structures behind a straightforward API.
> +the character device instead. Version 2 of libgpiod requires GPIO character
> +device uAPI v2 which was first released in linux v5.10. This library
> +encapsulates the ioctl calls and data structures behind a straightforward API.
>
Minor nit - drop the "v" in v5.10 to be consistent with other use,
including the 4.8 in the same paragraph?
Cheers,
Kent.
next prev parent reply other threads:[~2024-01-16 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 9:40 [libgpiod][PATCH v2] README: mention the Linux 5.10 requirement for libgpiod v2 Bartosz Golaszewski
2024-01-16 10:08 ` Kent Gibson [this message]
2024-01-16 10:09 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116100834.GA3474@rigel \
--to=warthog618@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=erik.schilling@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=phil@gadgetoid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox