From: kernel test robot <lkp@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>, Alex Elder <elder@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Paul E . McKenney" <paulmck@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 20/22] gpio: protect the pointer to gpio_chip in gpio_device with SRCU
Date: Wed, 31 Jan 2024 10:20:40 +0800 [thread overview]
Message-ID: <202401311050.YNdm98Hv-lkp@intel.com> (raw)
In-Reply-To: <20240130124828.14678-21-brgl@bgdev.pl>
Hi Bartosz,
kernel test robot noticed the following build warnings:
[auto build test WARNING on brgl/gpio/for-next]
[also build test WARNING on linus/master v6.8-rc2 next-20240130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/gpio-protect-the-list-of-GPIO-devices-with-SRCU/20240130-205537
base: https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
patch link: https://lore.kernel.org/r/20240130124828.14678-21-brgl%40bgdev.pl
patch subject: [PATCH 20/22] gpio: protect the pointer to gpio_chip in gpio_device with SRCU
config: x86_64-randconfig-122-20240131 (https://download.01.org/0day-ci/archive/20240131/202401311050.YNdm98Hv-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240131/202401311050.YNdm98Hv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401311050.YNdm98Hv-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/gpio/gpiolib.c:444:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:444:22: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:444:22: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:1103:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:1103:9: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:1103:9: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:1182:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:1182:22: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:1182:22: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:2970:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:2970:14: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:2970:14: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:3004:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:3004:22: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:3004:22: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:3585:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:3585:14: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:3585:14: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:4772:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:4772:14: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:4772:14: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c:4846:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.c:4846:14: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.c:4846:14: sparse: struct gpio_chip *
drivers/gpio/gpiolib.c: note: in included file:
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
>> drivers/gpio/gpiolib.h:202:1: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip [noderef] __rcu *
drivers/gpio/gpiolib.h:202:1: sparse: struct gpio_chip *
vim +444 drivers/gpio/gpiolib.c
422
423 /*
424 * Convert a GPIO name to its descriptor
425 * Note that there is no guarantee that GPIO names are globally unique!
426 * Hence this function will return, if it exists, a reference to the first GPIO
427 * line found that matches the given name.
428 */
429 static struct gpio_desc *gpio_name_to_desc(const char * const name)
430 {
431 struct gpio_device *gdev;
432 struct gpio_desc *desc;
433 struct gpio_chip *gc;
434
435 if (!name)
436 return NULL;
437
438 guard(srcu)(&gpio_devices_srcu);
439
440 list_for_each_entry_srcu(gdev, &gpio_devices, list,
441 srcu_read_lock_held(&gpio_devices_srcu)) {
442 guard(srcu)(&gdev->srcu);
443
> 444 gc = rcu_dereference(gdev->chip);
445 if (!gc)
446 continue;
447
448 for_each_gpio_desc(gc, desc) {
449 if (desc->name && !strcmp(desc->name, name))
450 return desc;
451 }
452 }
453
454 return NULL;
455 }
456
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-01-31 2:21 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 12:48 [PATCH 00/22] gpio: rework locking and object life-time control Bartosz Golaszewski
2024-01-30 12:48 ` [PATCH 01/22] gpio: protect the list of GPIO devices with SRCU Bartosz Golaszewski
2024-01-31 9:34 ` kernel test robot
2024-01-31 12:45 ` Bartosz Golaszewski
2024-01-31 15:01 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 02/22] gpio: of: assign and read the hog pointer atomically Bartosz Golaszewski
2024-01-31 17:38 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 03/22] gpio: remove unused logging helpers Bartosz Golaszewski
2024-01-31 17:39 ` Linus Walleij
2024-01-31 18:08 ` Bartosz Golaszewski
2024-01-31 20:33 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 04/22] gpio: provide and use gpiod_get_label() Bartosz Golaszewski
2024-01-31 19:36 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 05/22] gpio: don't set label from irq helpers Bartosz Golaszewski
2024-01-31 19:38 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 06/22] gpio: add SRCU infrastructure to struct gpio_desc Bartosz Golaszewski
2024-01-31 19:35 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 07/22] gpio: protect the descriptor label with SRCU Bartosz Golaszewski
2024-01-31 19:41 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 08/22] gpio: sysfs: use gpio_device_find() to iterate over existing devices Bartosz Golaszewski
2024-01-31 19:42 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 09/22] gpio: remove gpio_lock Bartosz Golaszewski
2024-01-31 19:51 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 10/22] gpio: reinforce desc->flags handling Bartosz Golaszewski
2024-01-31 20:01 ` Linus Walleij
2024-01-31 20:35 ` Linus Walleij
2024-02-01 18:30 ` Bartosz Golaszewski
2024-01-30 12:48 ` [PATCH 11/22] gpio: remove unneeded code from gpio_device_get_desc() Bartosz Golaszewski
2024-01-31 20:02 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 12/22] gpio: sysfs: extend the critical section for unregistering sysfs devices Bartosz Golaszewski
2024-01-31 20:06 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 13/22] gpio: sysfs: pass the GPIO device - not chip - to sysfs callbacks Bartosz Golaszewski
2024-01-31 20:09 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 14/22] gpio: cdev: replace gpiochip_get_desc() with gpio_device_get_desc() Bartosz Golaszewski
2024-01-31 20:10 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 15/22] gpio: cdev: don't access gdev->chip if it's not needed Bartosz Golaszewski
2024-01-31 20:11 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 16/22] gpio: reduce the functionality of validate_desc() Bartosz Golaszewski
2024-01-31 20:16 ` Linus Walleij
2024-01-31 20:19 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 17/22] gpio: remove unnecessary checks from gpiod_to_chip() Bartosz Golaszewski
2024-01-30 12:48 ` [PATCH 18/22] gpio: add the can_sleep flag to struct gpio_device Bartosz Golaszewski
2024-01-31 20:17 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 19/22] gpio: add SRCU infrastructure " Bartosz Golaszewski
2024-01-30 12:48 ` [PATCH 20/22] gpio: protect the pointer to gpio_chip in gpio_device with SRCU Bartosz Golaszewski
2024-01-31 0:41 ` kernel test robot
2024-01-31 8:15 ` Bartosz Golaszewski
2024-01-31 2:20 ` kernel test robot [this message]
2024-01-31 9:02 ` Bartosz Golaszewski
2024-01-31 9:24 ` Paul E. McKenney
2024-01-31 9:28 ` Bartosz Golaszewski
2024-01-31 9:41 ` Bartosz Golaszewski
2024-01-31 9:42 ` Paul E. McKenney
2024-01-31 10:17 ` brgl
2024-01-31 11:00 ` Paul E. McKenney
2024-01-31 12:23 ` Bartosz Golaszewski
2024-01-31 20:23 ` Linus Walleij
2024-02-01 5:03 ` Dan Carpenter
2024-02-01 7:57 ` Bartosz Golaszewski
2024-01-30 12:48 ` [PATCH 21/22] gpio: remove the RW semaphore from the GPIO device Bartosz Golaszewski
2024-01-31 20:24 ` Linus Walleij
2024-01-30 12:48 ` [PATCH 22/22] gpio: mark unsafe gpio_chip manipulators as deprecated Bartosz Golaszewski
2024-01-31 20:29 ` Linus Walleij
2024-02-01 9:14 ` Bartosz Golaszewski
2024-01-31 20:32 ` [PATCH 00/22] gpio: rework locking and object life-time control Linus Walleij
2024-02-01 8:43 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401311050.YNdm98Hv-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=elder@linaro.org \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=warthog618@gmail.com \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).