From: Tony Lindgren <tony@atomide.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Thomas Richard" <thomas.richard@bootlin.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com
Subject: Re: [PATCH v2 02/15] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq
Date: Mon, 5 Feb 2024 09:21:11 +0200 [thread overview]
Message-ID: <20240205072111.GD5185@atomide.com> (raw)
In-Reply-To: <6hyubhrho6xbki6yxtmqedylc2gpeyj4yu5gtrjrq4nsthcr7g@elfukmqeve2a>
* Andi Shyti <andi.shyti@kernel.org> [240129 22:49]:
> On Sat, Jan 27, 2024 at 11:31:11PM +0100, Linus Walleij wrote:
> > On Fri, Jan 26, 2024 at 3:37 PM Thomas Richard
> > <thomas.richard@bootlin.com> wrote:
> >
> > > The goal is to extend the active period of pinctrl.
> > > Some devices may need active pinctrl after suspend() and/or before
> > > resume().
> > > So move suspend()/resume() to suspend_noirq()/resume_noirq() in order to
> > > have active pinctrl until suspend_noirq() (included), and from
> > > resume_noirq() (included).
> > >
> > > The deprecated API has been removed to use the new one (dev_pm_ops struct).
> > >
> > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Do you want to merge this as a series or is this something I
> > should just apply?
>
> there is still a comment from me pending.
FYI I gave this a brief test and things seem to work fine for me. Sounds
like there will be another revision though so I'll test again then.
Regards,
Tony
next prev parent reply other threads:[~2024-02-05 7:22 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 14:36 [PATCH v2 00/15] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-01-26 14:36 ` [PATCH v2 01/15] gpio: pca953x: move suspend()/resume() to suspend_noirq()/resume_noirq() Thomas Richard
2024-01-26 21:30 ` Andy Shevchenko
2024-01-27 20:59 ` Bartosz Golaszewski
2024-01-27 21:46 ` Andi Shyti
2024-02-05 6:58 ` Tony Lindgren
2024-01-26 14:36 ` [PATCH v2 02/15] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq Thomas Richard
2024-01-26 21:31 ` Andy Shevchenko
2024-01-27 21:53 ` Andi Shyti
2024-01-27 22:31 ` Linus Walleij
2024-01-29 22:49 ` Andi Shyti
2024-02-05 7:21 ` Tony Lindgren [this message]
2024-02-08 15:52 ` Thomas Richard
2024-01-26 14:36 ` [PATCH v2 03/15] i2c: omap: wakeup the controller during suspend() callback Thomas Richard
2024-01-29 22:48 ` Andi Shyti
2024-01-26 14:36 ` [PATCH v2 04/15] mux: add mux_chip_resume() function Thomas Richard
2024-01-26 21:28 ` Andy Shevchenko
2024-01-30 16:38 ` Thomas Richard
2024-01-29 22:54 ` Andi Shyti
2024-01-30 8:25 ` Peter Rosin
2024-01-30 16:24 ` Thomas Richard
2024-01-26 14:36 ` [PATCH v2 05/15] mux: mmio: add resume support Thomas Richard
2024-01-26 21:32 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 06/15] phy: ti: phy-j721e-wiz: make wiz_clock_init callable multiple times Thomas Richard
2024-01-26 21:38 ` Andy Shevchenko
2024-01-29 23:02 ` Andi Shyti
2024-01-26 14:36 ` [PATCH v2 07/15] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-01-26 21:42 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 08/15] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-01-26 21:44 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 09/15] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-01-26 21:45 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 10/15] phy: cadence-torrent: add already_configured to struct cdns_torrent_phy Thomas Richard
2024-01-26 14:36 ` [PATCH v2 11/15] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-01-26 14:36 ` [PATCH v2 12/15] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-01-26 21:48 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup() Thomas Richard
2024-01-26 21:43 ` Bjorn Helgaas
2024-01-26 21:50 ` Andy Shevchenko
2024-01-29 22:16 ` Bjorn Helgaas
2024-01-29 22:24 ` Bjorn Helgaas
2024-01-26 14:36 ` [PATCH v2 14/15] PCI: j721e: add reset GPIO to struct j721e_pcie Thomas Richard
2024-01-26 21:52 ` Andy Shevchenko
2024-01-26 14:36 ` [PATCH v2 15/15] PCI: j721e: add suspend and resume support Thomas Richard
2024-01-26 21:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205072111.GD5185@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).