From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>, Alex Elder <elder@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Paul E . McKenney" <paulmck@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>, Mark Brown <broonie@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v2 0/4] gpio: fix SRCU bugs
Date: Wed, 14 Feb 2024 09:44:15 +0100 [thread overview]
Message-ID: <20240214084419.6194-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Here are four fixes to some bugs in recent SRCU changes. The first one fixes
an actual race condition. The other three just make lockdep happy.
v1 -> v2:
- use srcu_dereference() instead of rcu_dereference_protected() as
advised by Paul
- add a patch using rcu_dereference_check(..., 1) in deprecated
interfaces that return the address of the RCU-protected chip structure
to external users (who shouldn't use it anyway but well...)
- pick up review tags for patches 1/4 and 2/4
Bartosz Golaszewski (4):
gpio: take the SRCU read lock in gpiod_hog()
gpio: cdev: use correct pointer accessors with SRCU
gpio: use srcu_dereference() with SRCU-protected pointers
gpio: don't let lockdep complain about inherently dangerous RCU usage
drivers/gpio/gpiolib-cdev.c | 25 ++++++++++++-------------
drivers/gpio/gpiolib-sysfs.c | 5 +++--
drivers/gpio/gpiolib.c | 32 ++++++++++++++++++--------------
drivers/gpio/gpiolib.h | 3 ++-
4 files changed, 35 insertions(+), 30 deletions(-)
--
2.40.1
next reply other threads:[~2024-02-14 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 8:44 Bartosz Golaszewski [this message]
2024-02-14 8:44 ` [PATCH v2 1/4] gpio: take the SRCU read lock in gpiod_hog() Bartosz Golaszewski
2024-02-14 8:44 ` [PATCH v2 2/4] gpio: cdev: use correct pointer accessors with SRCU Bartosz Golaszewski
[not found] ` <CGME20240216103104eucas1p1fac9b939d4af1648d222963fbef59645@eucas1p1.samsung.com>
2024-02-16 10:31 ` Marek Szyprowski
2024-02-16 10:50 ` Bartosz Golaszewski
2024-02-26 14:27 ` kernel test robot
2024-02-27 16:44 ` Bartosz Golaszewski
2024-02-14 8:44 ` [PATCH v2 3/4] gpio: use srcu_dereference() with SRCU-protected pointers Bartosz Golaszewski
2024-02-14 8:44 ` [PATCH v2 4/4] gpio: don't let lockdep complain about inherently dangerous RCU usage Bartosz Golaszewski
2024-02-14 12:53 ` [PATCH v2 0/4] gpio: fix SRCU bugs Andy Shevchenko
2024-02-14 13:02 ` Bartosz Golaszewski
2024-02-14 13:17 ` Mark Brown
2024-02-14 13:22 ` Bartosz Golaszewski
2024-02-14 18:44 ` Paul E. McKenney
2024-02-14 19:08 ` Bartosz Golaszewski
2024-02-14 20:44 ` Paul E. McKenney
2024-02-21 21:45 ` Linus Walleij
2024-02-15 7:43 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214084419.6194-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=elder@linaro.org \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=warthog618@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).