From: Arturas Moskvinas <arturas.moskvinas@gmail.com>
To: fabio.estevam@nxp.com, linus.walleij@linaro.org, brgl@bgdev.pl,
u.kleine-koenig@pengutronix.de,
andriy.shevchenko@linux.intel.com
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Arturas Moskvinas <arturas.moskvinas@gmail.com>
Subject: [PATCH] gpio: 74x164: Enable output pins after registers are reset
Date: Mon, 26 Feb 2024 15:46:56 +0200 [thread overview]
Message-ID: <20240226134656.608559-1-arturas.moskvinas@gmail.com> (raw)
Move output enabling after chip registers are cleared.
Signed-off-by: Arturas Moskvinas <arturas.moskvinas@gmail.com>
---
drivers/gpio/gpio-74x164.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
index e00c33310517..753e7be039e4 100644
--- a/drivers/gpio/gpio-74x164.c
+++ b/drivers/gpio/gpio-74x164.c
@@ -127,8 +127,6 @@ static int gen_74x164_probe(struct spi_device *spi)
if (IS_ERR(chip->gpiod_oe))
return PTR_ERR(chip->gpiod_oe);
- gpiod_set_value_cansleep(chip->gpiod_oe, 1);
-
spi_set_drvdata(spi, chip);
chip->gpio_chip.label = spi->modalias;
@@ -153,6 +151,8 @@ static int gen_74x164_probe(struct spi_device *spi)
goto exit_destroy;
}
+ gpiod_set_value_cansleep(chip->gpiod_oe, 1);
+
ret = gpiochip_add_data(&chip->gpio_chip, chip);
if (!ret)
return 0;
base-commit: d206a76d7d2726f3b096037f2079ce0bd3ba329b
--
2.43.2
next reply other threads:[~2024-02-26 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 13:46 Arturas Moskvinas [this message]
2024-02-26 14:01 ` [PATCH] gpio: 74x164: Enable output pins after registers are reset Andy Shevchenko
2024-02-27 6:58 ` Arturas Moskvinas
2024-02-27 13:14 ` Bartosz Golaszewski
2024-02-27 14:53 ` Andy Shevchenko
2024-02-27 19:11 ` Arturas Moskvinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226134656.608559-1-arturas.moskvinas@gmail.com \
--to=arturas.moskvinas@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=fabio.estevam@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox