From: kernel test robot <lkp@intel.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
David Bauer <mail@david-bauer.net>
Subject: [linusw-pinctrl:b4/awinic-aw9523 2/2] drivers/pinctrl/pinctrl-aw9523.c:582: warning: Function parameter or struct member 'awi' not described in '_aw9523_gpio_get_multiple'
Date: Tue, 5 Mar 2024 09:36:40 +0800 [thread overview]
Message-ID: <202403050916.KBtE6eEj-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git b4/awinic-aw9523
head: 70c38171f464ba4b47c120a90c11388a43fffa6a
commit: 70c38171f464ba4b47c120a90c11388a43fffa6a [2/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240305/202403050916.KBtE6eEj-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240305/202403050916.KBtE6eEj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403050916.KBtE6eEj-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/pinctrl/pinctrl-aw9523.c:582: warning: Function parameter or struct member 'awi' not described in '_aw9523_gpio_get_multiple'
>> drivers/pinctrl/pinctrl-aw9523.c:582: warning: Function parameter or struct member 'mask' not described in '_aw9523_gpio_get_multiple'
>> drivers/pinctrl/pinctrl-aw9523.c:582: warning: Excess function parameter 'regmap' description in '_aw9523_gpio_get_multiple'
>> drivers/pinctrl/pinctrl-aw9523.c:582: warning: Excess function parameter 'pin' description in '_aw9523_gpio_get_multiple'
vim +582 drivers/pinctrl/pinctrl-aw9523.c
570
571 /**
572 * _aw9523_gpio_get_multiple - Get I/O state for an entire port
573 * @regmap: Regmap structure
574 * @pin: gpiolib pin number
575 * @regbit: hw pin index, used to retrieve port number
576 * @state: returned port I/O state
577 *
578 * Return: Zero for success or negative number for error
579 */
580 static int _aw9523_gpio_get_multiple(struct aw9523 *awi, u8 regbit,
581 u8 *state, u8 mask)
> 582 {
583 u32 dir_in, val;
584 u8 m;
585 int ret;
586
587 /* Registers are 8-bits wide */
588 ret = regmap_read(awi->regmap, AW9523_REG_CONF_STATE(regbit), &dir_in);
589 if (ret)
590 return ret;
591 *state = 0;
592
593 m = mask & dir_in;
594 if (m) {
595 ret = regmap_read(awi->regmap, AW9523_REG_IN_STATE(regbit),
596 &val);
597 if (ret)
598 return ret;
599 *state |= (u8)val & m;
600 }
601
602 m = mask & ~dir_in;
603 if (m) {
604 ret = regmap_read(awi->regmap, AW9523_REG_OUT_STATE(regbit),
605 &val);
606 if (ret)
607 return ret;
608 *state |= (u8)val & m;
609 }
610
611 return 0;
612 }
613
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-03-05 1:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403050916.KBtE6eEj-lkp@intel.com \
--to=lkp@intel.com \
--cc=angelogioacchino.delregno@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mail@david-bauer.net \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).