* [linusw-pinctrl:ib-nomadik-gpio 28/28] drivers/gpio/gpio-nomadik.c:589:4: warning: format specifies type 'void *' but the argument has type 'long'
@ 2024-03-06 21:09 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-03-06 21:09 UTC (permalink / raw)
To: Linus Walleij; +Cc: llvm, oe-kbuild-all, linux-gpio
tree: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git ib-nomadik-gpio
head: efaa90ed2cff038f12c077e9b040b97ac362b09c
commit: efaa90ed2cff038f12c077e9b040b97ac362b09c [28/28] gpio: nomadik: Back out some managed resources
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20240307/202403070521.gdNupw2n-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 325f51237252e6dab8e4e1ea1fa7acbb4faee1cd)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240307/202403070521.gdNupw2n-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403070521.gdNupw2n-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:78:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
| ^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
102 | #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
| ^
In file included from drivers/gpio/gpio-nomadik.c:23:
In file included from include/linux/gpio/driver.h:8:
In file included from include/linux/irqchip/chained_irq.h:10:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:78:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
| ^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
115 | #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
| ^
In file included from drivers/gpio/gpio-nomadik.c:23:
In file included from include/linux/gpio/driver.h:8:
In file included from include/linux/irqchip/chained_irq.h:10:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:78:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:692:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
692 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:700:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
700 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:708:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
708 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:717:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
717 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:726:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
726 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:735:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
735 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
In file included from drivers/gpio/gpio-nomadik.c:23:
In file included from include/linux/gpio/driver.h:8:
In file included from include/linux/irqchip/chained_irq.h:10:
In file included from include/linux/irq.h:591:
In file included from arch/s390/include/asm/hw_irq.h:6:
In file included from include/linux/pci.h:37:
In file included from include/linux/device.h:32:
In file included from include/linux/device/driver.h:21:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:173:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2188:
include/linux/vmstat.h:508:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
508 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
509 | item];
| ~~~~
include/linux/vmstat.h:515:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
515 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
516 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:527:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
527 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
528 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:536:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
536 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
537 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpio/gpio-nomadik.c:589:4: warning: format specifies type 'void *' but the argument has type 'long' [-Wformat]
588 | dev_err(dev, "failed getting reset control: %pe\n",
| ~~
| %ld
589 | PTR_ERR(reset));
| ^~~~~~~~~~~~~~
include/linux/dev_printk.h:144:65: note: expanded from macro 'dev_err'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ~~~ ^~~~~~~~~~~
18 warnings generated.
vim +589 drivers/gpio/gpio-nomadik.c
966942ae493650 Théo Lebrun 2024-02-28 543
efaa90ed2cff03 Linus Walleij 2024-03-05 544 nmk_chip = devm_kzalloc(dev, sizeof(*nmk_chip), GFP_KERNEL);
966942ae493650 Théo Lebrun 2024-02-28 545 if (!nmk_chip) {
966942ae493650 Théo Lebrun 2024-02-28 546 platform_device_put(gpio_pdev);
966942ae493650 Théo Lebrun 2024-02-28 547 return ERR_PTR(-ENOMEM);
966942ae493650 Théo Lebrun 2024-02-28 548 }
966942ae493650 Théo Lebrun 2024-02-28 549
50bc2a4953cceb Théo Lebrun 2024-02-28 550 if (device_property_read_u32(gpio_dev, "ngpios", &ngpio)) {
50bc2a4953cceb Théo Lebrun 2024-02-28 551 ngpio = NMK_GPIO_PER_CHIP;
efaa90ed2cff03 Linus Walleij 2024-03-05 552 dev_dbg(dev, "populate: using default ngpio (%u)\n", ngpio);
50bc2a4953cceb Théo Lebrun 2024-02-28 553 }
50bc2a4953cceb Théo Lebrun 2024-02-28 554
3c30cc26df0a3f Théo Lebrun 2024-02-28 555 nmk_chip->is_mobileye_soc = device_is_compatible(gpio_dev,
3c30cc26df0a3f Théo Lebrun 2024-02-28 556 "mobileye,eyeq5-gpio");
966942ae493650 Théo Lebrun 2024-02-28 557 nmk_chip->bank = id;
966942ae493650 Théo Lebrun 2024-02-28 558 chip = &nmk_chip->chip;
75d270fda64d4e Théo Lebrun 2024-02-28 559 chip->base = -1;
50bc2a4953cceb Théo Lebrun 2024-02-28 560 chip->ngpio = ngpio;
0b95fcd1f42f0f Théo Lebrun 2024-02-28 561 chip->label = dev_name(gpio_dev);
0b95fcd1f42f0f Théo Lebrun 2024-02-28 562 chip->parent = gpio_dev;
966942ae493650 Théo Lebrun 2024-02-28 563
efaa90ed2cff03 Linus Walleij 2024-03-05 564 /* NOTE: different devices! No devm_platform_ioremap_resource() here! */
efaa90ed2cff03 Linus Walleij 2024-03-05 565 res = platform_get_resource(gpio_pdev, IORESOURCE_MEM, 0);
efaa90ed2cff03 Linus Walleij 2024-03-05 566 base = devm_ioremap_resource(dev, res);
966942ae493650 Théo Lebrun 2024-02-28 567 if (IS_ERR(base)) {
966942ae493650 Théo Lebrun 2024-02-28 568 platform_device_put(gpio_pdev);
966942ae493650 Théo Lebrun 2024-02-28 569 return ERR_CAST(base);
966942ae493650 Théo Lebrun 2024-02-28 570 }
966942ae493650 Théo Lebrun 2024-02-28 571 nmk_chip->addr = base;
966942ae493650 Théo Lebrun 2024-02-28 572
efaa90ed2cff03 Linus Walleij 2024-03-05 573 /* NOTE: do not use devm_ here! */
efaa90ed2cff03 Linus Walleij 2024-03-05 574 clk = clk_get_optional(gpio_dev, NULL);
966942ae493650 Théo Lebrun 2024-02-28 575 if (IS_ERR(clk)) {
966942ae493650 Théo Lebrun 2024-02-28 576 platform_device_put(gpio_pdev);
efaa90ed2cff03 Linus Walleij 2024-03-05 577 return ERR_CAST(clk);
966942ae493650 Théo Lebrun 2024-02-28 578 }
966942ae493650 Théo Lebrun 2024-02-28 579 clk_prepare(clk);
966942ae493650 Théo Lebrun 2024-02-28 580 nmk_chip->clk = clk;
966942ae493650 Théo Lebrun 2024-02-28 581
efaa90ed2cff03 Linus Walleij 2024-03-05 582 /* NOTE: do not use devm_ here! */
efaa90ed2cff03 Linus Walleij 2024-03-05 583 reset = reset_control_get_optional_shared(gpio_dev, NULL);
6ad679cfaeea92 Théo Lebrun 2024-02-28 584 if (IS_ERR(reset)) {
efaa90ed2cff03 Linus Walleij 2024-03-05 585 clk_unprepare(clk);
efaa90ed2cff03 Linus Walleij 2024-03-05 586 clk_put(clk);
efaa90ed2cff03 Linus Walleij 2024-03-05 587 platform_device_put(gpio_pdev);
efaa90ed2cff03 Linus Walleij 2024-03-05 588 dev_err(dev, "failed getting reset control: %pe\n",
6ad679cfaeea92 Théo Lebrun 2024-02-28 @589 PTR_ERR(reset));
6ad679cfaeea92 Théo Lebrun 2024-02-28 590 return ERR_CAST(reset);
6ad679cfaeea92 Théo Lebrun 2024-02-28 591 }
6ad679cfaeea92 Théo Lebrun 2024-02-28 592
6ad679cfaeea92 Théo Lebrun 2024-02-28 593 /*
6ad679cfaeea92 Théo Lebrun 2024-02-28 594 * Reset might be shared and asserts/deasserts calls are unbalanced. We
6ad679cfaeea92 Théo Lebrun 2024-02-28 595 * only support sharing this reset with other gpio-nomadik devices that
6ad679cfaeea92 Théo Lebrun 2024-02-28 596 * use this reset to ensure deassertion at probe.
6ad679cfaeea92 Théo Lebrun 2024-02-28 597 */
6ad679cfaeea92 Théo Lebrun 2024-02-28 598 ret = reset_control_deassert(reset);
6ad679cfaeea92 Théo Lebrun 2024-02-28 599 if (ret) {
efaa90ed2cff03 Linus Walleij 2024-03-05 600 reset_control_put(reset);
efaa90ed2cff03 Linus Walleij 2024-03-05 601 clk_unprepare(clk);
efaa90ed2cff03 Linus Walleij 2024-03-05 602 clk_put(clk);
efaa90ed2cff03 Linus Walleij 2024-03-05 603 platform_device_put(gpio_pdev);
efaa90ed2cff03 Linus Walleij 2024-03-05 604 dev_err(dev, "failed reset deassert: %d\n", ret);
6ad679cfaeea92 Théo Lebrun 2024-02-28 605 return ERR_PTR(ret);
6ad679cfaeea92 Théo Lebrun 2024-02-28 606 }
6ad679cfaeea92 Théo Lebrun 2024-02-28 607
:::::: The code at line 589 was first introduced by commit
:::::: 6ad679cfaeea9291e9dce3247e34656080fc1d29 gpio: nomadik: grab optional reset control and deassert it at probe
:::::: TO: Théo Lebrun <theo.lebrun@bootlin.com>
:::::: CC: Linus Walleij <linus.walleij@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-06 21:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-06 21:09 [linusw-pinctrl:ib-nomadik-gpio 28/28] drivers/gpio/gpio-nomadik.c:589:4: warning: format specifies type 'void *' but the argument has type 'long' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).