From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E932520B35; Fri, 8 Mar 2024 08:43:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709887422; cv=none; b=h2d9+Ok6VdVumv8oqcLxsWS0bJaTOg4wyCuKyAHYk4E5/wg+/s+80YAdHrLg7XSAmJWhqQkcvVzDbSNu6r7M2Q46WHVjCyXqpsm51e9zO1Pz129H66r4MyC0kPD83gFmB1mwon49WGgSwVs59gHEgI0ByjFWpCzfmt919aSdhNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709887422; c=relaxed/simple; bh=aq/DY06lWHUt/eFJo+xen0fLGamPz9fKyECMARilshg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FTigA6M4Bv+mut8vtZDkW/9d/uFsH4ViVgKJjupKp5BCFd55P7a3/OzXJW4Gi1VcA0VuzNtPppUZcx1i3v4yiomr16QTH+xcBCRQVd2ab7DiPl5I+zAcTfLWJwHQO8NAwT+1YOkHXjAT79Dl/LjZe+xIT4KJPsWRl0dVzgW9RfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=fgerG7Kw; arc=none smtp.client-ip=74.50.62.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="fgerG7Kw" Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 134EF6042D; Fri, 8 Mar 2024 08:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1709887419; bh=aq/DY06lWHUt/eFJo+xen0fLGamPz9fKyECMARilshg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fgerG7KwfJefNMJNLfcraXoH3qDf0WBpWM/+wFaNdiZvPvVAVU29lsiqjPLfSExw0 RfCfw6TWN4Svcb2zWCctQVs2I2hHQvStXzfEJMR8uq78nrHZnWsnVjfbJTToOz8AGy FOezl7jYUUTOs5w80Ph3aryTRe9U4IJsM6Ylv0eYhfVOpKex0N1baXsiPzChY7hWBb BL6IyTmAy1lUVVMYiBIS8EGRE5Q8tsoomQj/zY5pL3E+41HIYAU/BitF3RzYwYYhiJ a6BkG1psPAAYXbZQnlbTk4/lBjhtOp/k4X+3y5Qwrenq/ZPDE0TdkyZdgevSjaNDz4 WVFRVdPEAWCLA== Date: Fri, 8 Mar 2024 10:42:40 +0200 From: Tony Lindgren To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v4 03/18] i2c: omap: wakeup the controller during suspend() callback Message-ID: <20240308084240.GK52537@atomide.com> References: <20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com> <20240102-j7200-pcie-s2r-v4-3-6f1f53390c85@bootlin.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v4-3-6f1f53390c85@bootlin.com> * Thomas Richard [240304 15:36]: > A device may need the controller up during suspend_noirq() or > resume_noirq(). > But if the controller is autosuspended, there is no way to wakeup it during > suspend_noirq() or resume_noirq() because runtime pm is disabled at this > time. > > The suspend() callback wakes up the controller, so it is available until > its suspend_noirq() callback (pm_runtime_force_suspend()). > During the resume, it's restored by resume_noirq() callback > (pm_runtime_force_resume()). Then resume() callback enables autosuspend. Reviewed-by: Tony Lindgren