linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org, kernel test robot <lkp@intel.com>,
	 Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v2] gpio: nomadik: Fix debugfs without debugfs
Date: Sun, 10 Mar 2024 00:28:30 +0100	[thread overview]
Message-ID: <20240310-fix-nmk-debugfs-v2-1-5de562b27520@linaro.org> (raw)

When the code was extracted from the pin control driver the
non-debugfs compile path forgot to take into account that this
function is no longer static but shared.

Fix it by making it a non-static stub.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403091024.OZ4KCPBL-lkp@intel.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Add reported closes tags
- Link to v1: https://lore.kernel.org/r/20240310-fix-nmk-debugfs-v1-1-38fe65409c56@linaro.org
---
 drivers/gpio/gpio-nomadik.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
index 463a765620dc..7ea630f70ce3 100644
--- a/drivers/gpio/gpio-nomadik.c
+++ b/drivers/gpio/gpio-nomadik.c
@@ -486,11 +486,11 @@ static void nmk_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 
 #else
 
-static inline void nmk_gpio_dbg_show_one(struct seq_file *s,
-					 struct pinctrl_dev *pctldev,
-					 struct gpio_chip *chip,
-					 unsigned int offset,
-					 unsigned int gpio)
+void nmk_gpio_dbg_show_one(struct seq_file *s,
+			   struct pinctrl_dev *pctldev,
+			   struct gpio_chip *chip,
+			   unsigned int offset,
+			   unsigned int gpio)
 {
 }
 

---
base-commit: d295ad7ef0137b292289dc214b27993ddffeae15
change-id: 20240310-fix-nmk-debugfs-7daafae1bc33

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>


                 reply	other threads:[~2024-03-09 23:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240310-fix-nmk-debugfs-v2-1-5de562b27520@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=theo.lebrun@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).