linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@somainline.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 03/11] pinctrl: aw9523: Always try both ports in aw9523_gpio_set_multiple()
Date: Thu, 14 Mar 2024 01:52:06 +0200	[thread overview]
Message-ID: <20240313235422.180075-4-andy.shevchenko@gmail.com> (raw)
In-Reply-To: <20240313235422.180075-1-andy.shevchenko@gmail.com>

The ports are equivalent from the user's point of view. Don't limit
trying them both if writing to one fails.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/pinctrl/pinctrl-aw9523.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9523.c
index 65d523697b731..d93640a02d1d3 100644
--- a/drivers/pinctrl/pinctrl-aw9523.c
+++ b/drivers/pinctrl/pinctrl-aw9523.c
@@ -653,7 +653,7 @@ static void aw9523_gpio_set_multiple(struct gpio_chip *chip,
 	struct aw9523 *awi = gpiochip_get_data(chip);
 	u8 mask_lo, mask_hi, bits_lo, bits_hi;
 	unsigned int reg;
-	int ret = 0;
+	int ret;
 
 	mask_lo = *mask & U8_MAX;
 	mask_hi = (*mask >> 8) & U8_MAX;
@@ -663,10 +663,8 @@ static void aw9523_gpio_set_multiple(struct gpio_chip *chip,
 		bits_hi = (*bits >> 8) & U8_MAX;
 
 		ret = regmap_write_bits(awi->regmap, reg, mask_hi, bits_hi);
-		if (ret) {
+		if (ret)
 			dev_warn(awi->dev, "Cannot write port1 out level\n");
-			goto out;
-		}
 	}
 	if (mask_lo) {
 		reg = AW9523_REG_OUT_STATE(0);
@@ -675,7 +673,6 @@ static void aw9523_gpio_set_multiple(struct gpio_chip *chip,
 		if (ret)
 			dev_warn(awi->dev, "Cannot write port0 out level\n");
 	}
-out:
 	mutex_unlock(&awi->i2c_lock);
 }
 
-- 
2.44.0


  parent reply	other threads:[~2024-03-13 23:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 23:52 [PATCH v1 00/11] pinctrl: aw9523: number of cleanups Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 01/11] pinctrl: aw9523: Destroy mutex on ->remove() Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 02/11] pinctrl: aw9523: Use correct error code for not supported functionality Andy Shevchenko
2024-03-13 23:52 ` Andy Shevchenko [this message]
2024-03-13 23:52 ` [PATCH v1 04/11] pinctrl: aw9523: Make use of struct pinfunction and PINCTRL_PINFUNCTION() Andy Shevchenko
2024-03-14 22:22   ` kernel test robot
2024-03-15 11:12   ` kernel test robot
2024-03-13 23:52 ` [PATCH v1 05/11] pinctrl: aw9523: Use temporary variable for HW IRQ number Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 06/11] pinctrl: aw9523: Get rid of redundant ' & U8_MAX' pieces Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 07/11] pinctrl: aw9523: Remove unused irqchip field in struct aw9523_irq Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 08/11] pinctrl: aw9523: Make use of dev_err_probe() Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 09/11] pinctrl: aw9523: Sort headers and group pinctrl/* Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 10/11] pinctrl: aw9523: Fix indentation in a few places Andy Shevchenko
2024-03-13 23:52 ` [PATCH v1 11/11] pinctrl: aw9523: Remove redundant dependency to OF Andy Shevchenko
2024-03-14  7:04 ` [PATCH v1 00/11] pinctrl: aw9523: number of cleanups Dan Carpenter
2024-03-28  9:21 ` Linus Walleij
2024-03-28 14:14   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313235422.180075-4-andy.shevchenko@gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).