From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934F9224C6; Wed, 20 Mar 2024 07:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710920720; cv=none; b=EtHMpNuqFvYUo3BVo+9uN55jiPSQae7zl9PcHk0YBHYVPfWCdkrZSyPQEI6XmOSAkrv5mW6jzYzJREmo+3GllQcnK/r2MMXMWepBqBP/06KjHWt52UPAPz+Bjg8PtxmCQ78bITE1rlul3KWMCfiDGgliqnd05BU/fmLJCVIbadk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710920720; c=relaxed/simple; bh=7qSpsLonZkPp6n1sVROjtTe4FhN1SzwKxxvPmVPaxvo=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LdE6ZBBTLoKowvVRu+3NA5VyfNjnGbzesAbAtB6ydURvxyQYWKGExaEFvBCSRSuQxCT4yHb9q5/IO1P75yXRfaBTyyKb+JXVjByTYbA3Zgnr74ypiVvOofJKkJbUrBjHVQ3fLwzSJKgjydnznJMg+2xRCOtXOju8Jwqf+2nJP1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=zR4dYbbI; arc=none smtp.client-ip=198.47.19.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="zR4dYbbI" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 42K7iXW8064345; Wed, 20 Mar 2024 02:44:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1710920673; bh=G30qDNGsYpoAs9e2Fev9q4x3U8X+mKvech/LuR0V5SM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=zR4dYbbIOU0T9kSt2VAkyYXxgXqFflmKQJcJc+YRexUebfWrIRTYWDW/9HdGCRAH2 2KUlZh22RTmTpHqsFOz+C2TVKTzBC+DoK9AZodPH7VJPCFH79hW1rqqmURZtTPHqsv OyhxsW9BCi0nXXAUXKmJx4XlNhwYmsvj5qI2UeJE= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 42K7iX2x116495 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 Mar 2024 02:44:33 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 20 Mar 2024 02:44:32 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 20 Mar 2024 02:44:32 -0500 Received: from localhost (dhruva.dhcp.ti.com [172.24.227.68]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 42K7iVIb016176; Wed, 20 Mar 2024 02:44:32 -0500 Date: Wed, 20 Mar 2024 13:14:31 +0530 From: Dhruva Gole To: Thomas Richard CC: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , , , , , , , , , , , , Andy Shevchenko Subject: Re: [PATCH v4 02/18] pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq Message-ID: <20240320074431.6yzao3jlyaxuii7c@dhruva> References: <20240102-j7200-pcie-s2r-v4-0-6f1f53390c85@bootlin.com> <20240102-j7200-pcie-s2r-v4-2-6f1f53390c85@bootlin.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v4-2-6f1f53390c85@bootlin.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Hi, On Mar 04, 2024 at 16:35:45 +0100, Thomas Richard wrote: > The goal is to extend the active period of pinctrl. > Some devices may need active pinctrl after suspend() and/or before > resume(). > So move suspend()/resume() to suspend_noirq()/resume_noirq() in order to > have active pinctrl until suspend_noirq() (included), and from > resume_noirq() (included). > > The deprecated API has been removed to use the new one (dev_pm_ops struct). > > No need to check the pointer returned by dev_get_drvdata(), as > platform_set_drvdata() is called during the probe. > > Reviewed-by: Linus Walleij > Reviewed-by: Andy Shevchenko > Signed-off-by: Thomas Richard > --- I was planning to do this but didn't see particular benefit to it. Do you see the benefit on your specific device? Can you help me understand how? Not against the patch, just curious. Reviewed-by: Dhruva Gole -- Best regards, Dhruva