* [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently
@ 2024-04-10 6:41 Andy Shevchenko
2024-04-10 20:26 ` William Breathitt Gray
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Shevchenko @ 2024-04-10 6:41 UTC (permalink / raw)
To: Linus Walleij, William Breathitt Gray, linux-gpio, linux-kernel
Cc: William Breathitt Gray, Bartosz Golaszewski, Andy Shevchenko
The GPIO library expects the drivers to return -ENOTSUPP in some cases
and not using analogue POSIX code. Make the driver to follow this.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/gpio/gpio-pcie-idio-24.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
index 2efd1b1a0805f..7f7f95ad4343d 100644
--- a/drivers/gpio/gpio-pcie-idio-24.c
+++ b/drivers/gpio/gpio-pcie-idio-24.c
@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
case IDIO_24_CONTROL_REG:
/* We can only set direction for TTL/CMOS lines */
if (offset < 48)
- return -EOPNOTSUPP;
+ return -ENOTSUPP;
*reg = IDIO_24_CONTROL_REG;
*mask = CONTROL_REG_OUT_MODE;
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently
2024-04-10 6:41 [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently Andy Shevchenko
@ 2024-04-10 20:26 ` William Breathitt Gray
2024-04-12 10:28 ` Linus Walleij
2024-04-12 19:37 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: William Breathitt Gray @ 2024-04-10 20:26 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, linux-gpio, linux-kernel, Bartosz Golaszewski
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Wed, Apr 10, 2024 at 09:41:56AM +0300, Andy Shevchenko wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: William Breathitt Gray <wbg@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently
2024-04-10 6:41 [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently Andy Shevchenko
2024-04-10 20:26 ` William Breathitt Gray
@ 2024-04-12 10:28 ` Linus Walleij
2024-04-12 19:37 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2024-04-12 10:28 UTC (permalink / raw)
To: Andy Shevchenko
Cc: William Breathitt Gray, linux-gpio, linux-kernel,
William Breathitt Gray, Bartosz Golaszewski
On Wed, Apr 10, 2024 at 8:41 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently
2024-04-10 6:41 [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently Andy Shevchenko
2024-04-10 20:26 ` William Breathitt Gray
2024-04-12 10:28 ` Linus Walleij
@ 2024-04-12 19:37 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2024-04-12 19:37 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, William Breathitt Gray, linux-gpio, linux-kernel,
William Breathitt Gray
On Wed, Apr 10, 2024 at 8:41 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/gpio/gpio-pcie-idio-24.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
> index 2efd1b1a0805f..7f7f95ad4343d 100644
> --- a/drivers/gpio/gpio-pcie-idio-24.c
> +++ b/drivers/gpio/gpio-pcie-idio-24.c
> @@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
> case IDIO_24_CONTROL_REG:
> /* We can only set direction for TTL/CMOS lines */
> if (offset < 48)
> - return -EOPNOTSUPP;
> + return -ENOTSUPP;
>
> *reg = IDIO_24_CONTROL_REG;
> *mask = CONTROL_REG_OUT_MODE;
> --
> 2.44.0
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-12 19:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-10 6:41 [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently Andy Shevchenko
2024-04-10 20:26 ` William Breathitt Gray
2024-04-12 10:28 ` Linus Walleij
2024-04-12 19:37 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).