From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linus.walleij@linaro.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpiolib: cdev: fix uninitialised kfifo
Date: Tue, 14 May 2024 11:36:56 +0800 [thread overview]
Message-ID: <20240514033656.GA24922@rigel> (raw)
In-Reply-To: <171534996897.34114.8159265536879918834.b4-ty@linaro.org>
On Fri, May 10, 2024 at 04:06:16PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
>
> On Fri, 10 May 2024 14:53:42 +0800, Kent Gibson wrote:
> > If a line is requested with debounce, and that results in debouncing
> > in software, and the line is subsequently reconfigured to enable edge
> > detection then the allocation of the kfifo to contain edge events is
> > overlooked. This results in events being written to and read from an
> > unitialised kfifo. Read events are returned to userspace.
> >
> > Initialise the kfifo in the case where the software debounce is
> > already active.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] gpiolib: cdev: fix uninitialised kfifo
> commit: 3c1625fe5a2e0d68cd7b68156f02c1b5de09a161
>
I've got a patch series to tidy this up and catch any similar errors
earlier going forward.
It is of course based on this patch, but that isn't in gpio/for-next yet.
How should I proceed?
Cheers,
Kent.
next prev parent reply other threads:[~2024-05-14 3:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 6:53 [PATCH] gpiolib: cdev: fix uninitialised kfifo Kent Gibson
2024-05-10 14:06 ` Bartosz Golaszewski
2024-05-14 3:36 ` Kent Gibson [this message]
2024-05-14 6:56 ` Bartosz Golaszewski
2024-05-14 12:15 ` Kent Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514033656.GA24922@rigel \
--to=warthog618@gmail.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).