From: kernel test robot <lkp@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Paul Cercueil <paul@crapouillou.net>,
Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
Subject: Re: [PATCH v1 05/11] pinctrl: pinmux: Add a convenient define PINCTRL_FUNCTION_DESC()
Date: Tue, 28 May 2024 08:19:55 +0800 [thread overview]
Message-ID: <202405280739.VSX5oEnr-lkp@intel.com> (raw)
In-Reply-To: <20240527212742.1432960-6-andy.shevchenko@gmail.com>
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next linus/master v6.10-rc1 next-20240523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-berlin-Make-use-of-struct-pinfunction/20240528-053304
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20240527212742.1432960-6-andy.shevchenko%40gmail.com
patch subject: [PATCH v1 05/11] pinctrl: pinmux: Add a convenient define PINCTRL_FUNCTION_DESC()
config: sh-defconfig (https://download.01.org/0day-ci/archive/20240528/202405280739.VSX5oEnr-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240528/202405280739.VSX5oEnr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405280739.VSX5oEnr-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/pinctrl/pinmux.c:863: warning: Function parameter or struct member 'ngroups' not described in 'pinmux_generic_add_function'
>> drivers/pinctrl/pinmux.c:863: warning: Excess function parameter 'num_groups' description in 'pinmux_generic_add_function'
vim +863 drivers/pinctrl/pinmux.c
a76edc89b100e4 Tony Lindgren 2016-12-27 849
a76edc89b100e4 Tony Lindgren 2016-12-27 850 /**
6bffa7e1631d55 Geert Uytterhoeven 2017-04-03 851 * pinmux_generic_add_function() - adds a function group
a76edc89b100e4 Tony Lindgren 2016-12-27 852 * @pctldev: pin controller device
a76edc89b100e4 Tony Lindgren 2016-12-27 853 * @name: name of the function
a76edc89b100e4 Tony Lindgren 2016-12-27 854 * @groups: array of pin groups
a76edc89b100e4 Tony Lindgren 2016-12-27 855 * @num_groups: number of pin groups
a76edc89b100e4 Tony Lindgren 2016-12-27 856 * @data: pin controller driver specific data
a76edc89b100e4 Tony Lindgren 2016-12-27 857 */
a76edc89b100e4 Tony Lindgren 2016-12-27 858 int pinmux_generic_add_function(struct pinctrl_dev *pctldev,
a76edc89b100e4 Tony Lindgren 2016-12-27 859 const char *name,
bd0aae66c48208 Rafał Miłecki 2021-12-16 860 const char * const *groups,
368512f04e89e0 Andy Shevchenko 2024-05-28 861 const unsigned int ngroups,
a76edc89b100e4 Tony Lindgren 2016-12-27 862 void *data)
a76edc89b100e4 Tony Lindgren 2016-12-27 @863 {
a76edc89b100e4 Tony Lindgren 2016-12-27 864 struct function_desc *function;
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 865 int selector, error;
f913cfce4ee49a Tony Lindgren 2018-07-05 866
f913cfce4ee49a Tony Lindgren 2018-07-05 867 if (!name)
f913cfce4ee49a Tony Lindgren 2018-07-05 868 return -EINVAL;
f913cfce4ee49a Tony Lindgren 2018-07-05 869
f913cfce4ee49a Tony Lindgren 2018-07-05 870 selector = pinmux_func_name_to_selector(pctldev, name);
f913cfce4ee49a Tony Lindgren 2018-07-05 871 if (selector >= 0)
f913cfce4ee49a Tony Lindgren 2018-07-05 872 return selector;
f913cfce4ee49a Tony Lindgren 2018-07-05 873
f913cfce4ee49a Tony Lindgren 2018-07-05 874 selector = pctldev->num_functions;
a76edc89b100e4 Tony Lindgren 2016-12-27 875
a76edc89b100e4 Tony Lindgren 2016-12-27 876 function = devm_kzalloc(pctldev->dev, sizeof(*function), GFP_KERNEL);
a76edc89b100e4 Tony Lindgren 2016-12-27 877 if (!function)
a76edc89b100e4 Tony Lindgren 2016-12-27 878 return -ENOMEM;
a76edc89b100e4 Tony Lindgren 2016-12-27 879
368512f04e89e0 Andy Shevchenko 2024-05-28 880 function = PINCTRL_FUNCTION_DESC(name, groups, ngroups, data);
a76edc89b100e4 Tony Lindgren 2016-12-27 881
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 882 error = radix_tree_insert(&pctldev->pin_function_tree, selector, function);
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 883 if (error)
6ec89cd4d17bd5 Sergey Shtylyov 2023-07-19 884 return error;
a76edc89b100e4 Tony Lindgren 2016-12-27 885
a76edc89b100e4 Tony Lindgren 2016-12-27 886 pctldev->num_functions++;
a76edc89b100e4 Tony Lindgren 2016-12-27 887
f913cfce4ee49a Tony Lindgren 2018-07-05 888 return selector;
a76edc89b100e4 Tony Lindgren 2016-12-27 889 }
a76edc89b100e4 Tony Lindgren 2016-12-27 890 EXPORT_SYMBOL_GPL(pinmux_generic_add_function);
a76edc89b100e4 Tony Lindgren 2016-12-27 891
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-05-28 0:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 21:24 [PATCH v1 00/11] pinctrl: pinmux: Embed and reuse struct pinfunction Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 01/11] pinctrl: berlin: Make use of " Andy Shevchenko
2024-05-28 0:30 ` kernel test robot
2024-05-27 21:24 ` [PATCH v1 02/11] pinctrl: equilibrium: " Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 03/11] pinctrl: ingenic: Provide a helper macro INGENIC_PIN_FUNCTION() Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 04/11] pinctrl: mediatek: Provide a helper macro PINCTRL_PIN_FUNCTION() Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 05/11] pinctrl: pinmux: Add a convenient define PINCTRL_FUNCTION_DESC() Andy Shevchenko
2024-05-28 0:19 ` kernel test robot [this message]
2024-05-28 0:30 ` kernel test robot
2024-05-27 21:24 ` [PATCH v1 06/11] pinctrl: pinmux: Embed struct pinfunction into struct function_desc Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 07/11] pinctrl: imx: Convert to use func member Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 08/11] pinctrl: ingenic: " Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 09/11] pinctrl: keembay: " Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 10/11] pinctrl: mediatek: " Andy Shevchenko
2024-05-27 21:24 ` [PATCH v1 11/11] pinctrl: pinmux: Remove unused members from struct function_desc Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405280739.VSX5oEnr-lkp@intel.com \
--to=lkp@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paul@crapouillou.net \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sean.wang@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).