From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod][PATCH 0/8] tools: tests: fix shellcheck warnings
Date: Fri, 31 May 2024 21:45:04 +0800 [thread overview]
Message-ID: <20240531134512.443850-1-warthog618@gmail.com> (raw)
Following up on recent discussions, this series fixes all the warnings
detected by shellcheck. The resulting tools test script is now clean,
at least from the perspective of shellcheck.
These fixes do not correct any known issue, other than shellcheck
reporting them as potential problems, the intent is to remove common
shell issues that may impact future changes, and to simplify checking
that any subsequent changes to the test script constitute "good" shell.
All the patches other than Patch 8 address a particular warning.
They are reasonably self-explanatory, but each commit comment includes a
link to the relevant warning(s) which describes the issue and the
appropriate corrections.
Patch 8 addresses a number of warnings, all related to word splitting
and globbing, and those constitute the bulk of the changes.
Some of the earlier patches also address trivial splitting/globbing
issues where that would prevent a line being modified multiple times.
Cheers,
Kent.
Kent Gibson (8):
tools: tests: don't mix string and array
tools: tests: don't declare and assign separately
tools: tests: fix unused variables
tools: tests: use read -r to avoid mangling backslashes
tools: tests: don't use variables in printf format string
tools: tests: check exit code directly
tools: tests: shellcheck don't follow sourced file
tools: tests: avoid splitting and globbing
tools/gpio-tools-test.bash | 459 +++++++++++++++++++------------------
1 file changed, 234 insertions(+), 225 deletions(-)
--
2.39.2
next reply other threads:[~2024-05-31 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 13:45 Kent Gibson [this message]
2024-05-31 13:45 ` [libgpiod][PATCH 1/8] tools: tests: don't mix string and array Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 2/8] tools: tests: don't declare and assign separately Kent Gibson
2024-06-03 8:52 ` Bartosz Golaszewski
2024-06-03 8:58 ` Kent Gibson
2024-06-03 10:38 ` Bartosz Golaszewski
2024-06-03 10:39 ` Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 3/8] tools: tests: fix unused variables Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 4/8] tools: tests: use read -r to avoid mangling backslashes Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 5/8] tools: tests: don't use variables in printf format string Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 6/8] tools: tests: check exit code directly Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 7/8] tools: tests: shellcheck don't follow sourced file Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 8/8] tools: tests: avoid splitting and globbing Kent Gibson
2024-06-03 10:40 ` [libgpiod][PATCH 0/8] tools: tests: fix shellcheck warnings Bartosz Golaszewski
2024-06-03 10:43 ` Kent Gibson
2024-06-03 10:59 ` Kent Gibson
2024-06-03 11:51 ` Bartosz Golaszewski
2024-06-03 14:59 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240531134512.443850-1-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).