[PATCH] pinctrl: keembay: Fix func conversion in keembay_build_functions()

[PATCH] pinctrl: keembay: Fix func conversion in keembay_build_functions()

[Nathan Chancellor]

A recent refactoring to use the func member in struct function_desc
missed converting one uses of name in keembay_build_functions(),
resulting in a build failure:

  drivers/pinctrl/pinctrl-keembay.c: In function 'keembay_build_functions':
  drivers/pinctrl/pinctrl-keembay.c:1630:35: error: 'struct function_desc' has no member named 'name'
   1630 |                         if (!fdesc->name) {
        |                                   ^~

Perform the same conversion to resolve the build error.

Fixes: 73ee52205e5a ("pinctrl: keembay: Convert to use func member")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 drivers/pinctrl/pinctrl-keembay.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-keembay.c b/drivers/pinctrl/pinctrl-keembay.c
index 245a74ed97ee..b693f4787044 100644
--- a/drivers/pinctrl/pinctrl-keembay.c
+++ b/drivers/pinctrl/pinctrl-keembay.c
@@ -1627,7 +1627,7 @@ static int keembay_build_functions(struct keembay_pinctrl *kpc)
 			}
 
 			/* Setup new function for this mux we didn't see before */
-			if (!fdesc->name) {
+			if (!fdesc->func.name) {
 				fdesc->func.name = mux->name;
 				fdesc->func.ngroups = 1;
 				fdesc->data = &mux->mode;

---
base-commit: e53de87ac331eb2186477f69bf90e95d1ba39d55
change-id: 20240611-pinctrl-keembay-fix-func-conversion-70b98e2baa4c

Best regards,
-- 
Nathan Chancellor <nathan@kernel.org>

Re: [PATCH] pinctrl: keembay: Fix func conversion in keembay_build_functions()

[Andy Shevchenko]

On Tue, Jun 11, 2024 at 9:13 PM Nathan Chancellor <nathan@kernel.org> wrote:
>
> A recent refactoring to use the func member in struct function_desc
> missed converting one uses of name in keembay_build_functions(),
> resulting in a build failure:
>
>   drivers/pinctrl/pinctrl-keembay.c: In function 'keembay_build_functions':
>   drivers/pinctrl/pinctrl-keembay.c:1630:35: error: 'struct function_desc' has no member named 'name'
>    1630 |                         if (!fdesc->name) {
>         |                                   ^~
>
> Perform the same conversion to resolve the build error.

Oh, Keem Bay is ARM-based :-)
Thanks for finding and fixing this issue.
Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] pinctrl: keembay: Fix func conversion in keembay_build_functions()

[Linus Walleij]

On Tue, Jun 11, 2024 at 8:13 PM Nathan Chancellor <nathan@kernel.org> wrote:

> A recent refactoring to use the func member in struct function_desc
> missed converting one uses of name in keembay_build_functions(),
> resulting in a build failure:
>
>   drivers/pinctrl/pinctrl-keembay.c: In function 'keembay_build_functions':
>   drivers/pinctrl/pinctrl-keembay.c:1630:35: error: 'struct function_desc' has no member named 'name'
>    1630 |                         if (!fdesc->name) {
>         |                                   ^~
>
> Perform the same conversion to resolve the build error.
>
> Fixes: 73ee52205e5a ("pinctrl: keembay: Convert to use func member")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

I had cooked my own version of this fix but this came first so I applied this
instead.

Yours,
Linus Walleij