From: Dhruva Gole <d-gole@ti.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: <linux-gpio@vger.kernel.org>, Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: davinci: handle wakeup-source property, detect wake IRQs
Date: Thu, 18 Jul 2024 11:05:10 +0530 [thread overview]
Message-ID: <20240718053510.ywdv5c7fk3natknl@dhruva> (raw)
In-Reply-To: <20240718000935.2573288-3-khilman@baylibre.com>
On Jul 17, 2024 at 17:09:33 -0700, Kevin Hilman wrote:
> If the wakeup-source property is used for the GPIO controller, then
> mark the controller as wakeup capable.
>
> Further, if there are any GPIO IRQs that are marked as wakeup-enabled,
> then mark the GPIO controller as wakeup enabled also. Since the GPIO
> IRQs that are wake-enabled are dynamic, this is (re)calculated during
> each suspend (and cleared on resume.)
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>
> ---
> drivers/gpio/gpio-davinci.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index 1d0175d6350b..031aa7c30855 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -7,6 +7,7 @@
> */
>
> #include <linux/gpio/driver.h>
> +#include <linux/gpio/consumer.h>
Please sort this...
[...]
With that taken care,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Best regards,
Dhruva
prev parent reply other threads:[~2024-07-18 5:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 0:09 [PATCH 0/2] gpio: davinci: improve wakeup capabilities Kevin Hilman
2024-07-18 0:09 ` [PATCH 1/2] gpiolib: expose for_each_gpio_desc() to drivers Kevin Hilman
2024-07-18 4:52 ` Dhruva Gole
2024-07-18 0:09 ` [PATCH 2/2] gpio: davinci: handle wakeup-source property, detect wake IRQs Kevin Hilman
2024-07-18 5:35 ` Dhruva Gole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718053510.ywdv5c7fk3natknl@dhruva \
--to=d-gole@ti.com \
--cc=brgl@bgdev.pl \
--cc=j-keerthy@ti.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox