From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Benjamin Cabé" <kartben@gmail.com>,
"Kent Gibson" <warthog618@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH libgpiod 2/2] bindings: python: tests: check that event clock is property set in request
Date: Wed, 31 Jul 2024 12:46:58 +0200 [thread overview]
Message-ID: <20240731104658.93117-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20240731104658.93117-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
We currently only have a test-case that checks if the event clock
property is correctly set in the LineSettings object but not whether it
is actually passed to the line request. Extend the existing test-case for
line requests to account for event clocks as well.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
bindings/python/tests/tests_line_request.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/bindings/python/tests/tests_line_request.py b/bindings/python/tests/tests_line_request.py
index c79a324..dce5941 100644
--- a/bindings/python/tests/tests_line_request.py
+++ b/bindings/python/tests/tests_line_request.py
@@ -5,7 +5,7 @@ import errno
import gpiod
from . import gpiosim
-from gpiod.line import Direction, Drive, Edge, Value
+from gpiod.line import Clock, Direction, Drive, Edge, Value
from unittest import TestCase
Pull = gpiosim.Chip.Pull
@@ -302,12 +302,15 @@ class LineRequestComplexConfig(TestCase):
direction=Direction.OUTPUT, output_value=Value.ACTIVE
),
(1, 3, 5): gpiod.LineSettings(
- direction=Direction.INPUT, edge_detection=Edge.BOTH
+ direction=Direction.INPUT,
+ edge_detection=Edge.BOTH,
+ event_clock=Clock.REALTIME,
),
},
) as req:
self.assertEqual(chip.get_line_info(2).direction, Direction.OUTPUT)
self.assertEqual(chip.get_line_info(3).edge_detection, Edge.BOTH)
+ self.assertEqual(chip.get_line_info(5).event_clock, Clock.REALTIME)
class LineRequestMixedConfigByName(TestCase):
--
2.43.0
next prev parent reply other threads:[~2024-07-31 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 10:46 [PATCH libgpiod 1/2] bindings: python: properly pass event clock settings Bartosz Golaszewski
2024-07-31 10:46 ` Bartosz Golaszewski [this message]
2024-08-01 0:07 ` Kent Gibson
2024-08-01 7:55 ` Bartosz Golaszewski
2024-08-01 8:27 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731104658.93117-2-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=kartben@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox