Re: [PATCH 2/2] dt-bindings: pinctrl: Add rk3576 pinctrl bindings

Krzysztof Kozlowski
2024-08-04T09:58:12Z

On 02/08/2024 16:52, Detlev Casanova wrote:
> This adds the compatible string as well as the optional rockchip,sys-grf field.

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> ---
> .../devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> index 20e806dce1ecb..a202b6681624c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
> @@ -45,6 +45,7 @@ properties:
> - rockchip,rk3368-pinctrl
> - rockchip,rk3399-pinctrl
> - rockchip,rk3568-pinctrl
> + - rockchip,rk3576-pinctrl
> - rockchip,rk3588-pinctrl
> - rockchip,rv1108-pinctrl
> - rockchip,rv1126-pinctrl
> @@ -54,6 +55,11 @@ properties:
> description:
> The phandle of the syscon node for the GRF registers.
>
> + rockchip,sys-grf:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The phandle of the syscon node for the SYS GRF registers.

Describe what for.

Best regards,
Krzysztof