* [PATCH v1 1/1] pinctrl: stmfx: Use string_choices API instead of ternary operator
@ 2024-08-26 9:53 Andy Shevchenko
2024-08-30 22:11 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2024-08-26 9:53 UTC (permalink / raw)
To: Uwe Kleine-König, linux-gpio, linux-stm32, linux-arm-kernel,
linux-kernel
Cc: Linus Walleij, Maxime Coquelin, Alexandre Torgue, Andy Shevchenko
Use modern string_choices API instead of manually determining the
output using ternary operator.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-stmfx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index 6313be370eb7..d2c5321dd025 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -11,6 +11,7 @@
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/seq_file.h>
+#include <linux/string_choices.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinmux.h>
@@ -369,14 +370,14 @@ static void stmfx_pinconf_dbg_show(struct pinctrl_dev *pctldev,
return;
if (dir == GPIO_LINE_DIRECTION_OUT) {
- seq_printf(s, "output %s ", val ? "high" : "low");
+ seq_printf(s, "output %s ", str_high_low(val));
if (type)
seq_printf(s, "open drain %s internal pull-up ",
pupd ? "with" : "without");
else
seq_puts(s, "push pull no pull ");
} else {
- seq_printf(s, "input %s ", val ? "high" : "low");
+ seq_printf(s, "input %s ", str_high_low(val));
if (type)
seq_printf(s, "with internal pull-%s ",
pupd ? "up" : "down");
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] pinctrl: stmfx: Use string_choices API instead of ternary operator
2024-08-26 9:53 [PATCH v1 1/1] pinctrl: stmfx: Use string_choices API instead of ternary operator Andy Shevchenko
@ 2024-08-30 22:11 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2024-08-30 22:11 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Uwe Kleine-König, linux-gpio, linux-stm32, linux-arm-kernel,
linux-kernel, Maxime Coquelin, Alexandre Torgue
On Mon, Aug 26, 2024 at 11:53 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Use modern string_choices API instead of manually determining the
> output using ternary operator.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-30 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-26 9:53 [PATCH v1 1/1] pinctrl: stmfx: Use string_choices API instead of ternary operator Andy Shevchenko
2024-08-30 22:11 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).