From: Conor Dooley <conor@kernel.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
andrew@codeconstruct.com.au, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
BMC-SW@aspeedtech.com
Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700
Date: Fri, 30 Aug 2024 15:04:04 +0100 [thread overview]
Message-ID: <20240830-untangled-charting-48503e510ea7@spud> (raw)
In-Reply-To: <20240830034047.2251482-2-billy_tsai@aspeedtech.com>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
On Fri, Aug 30, 2024 at 11:40:44AM +0800, Billy Tsai wrote:
> The AST2700 is the 7th generation SoC from Aspeed, featuring two GPIO
> controllers: one with 12 GPIO pins and another with 216 GPIO pins.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> .../bindings/gpio/aspeed,ast2400-gpio.yaml | 46 ++++++++++++++++++-
> 1 file changed, 45 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
> index cf11aa7ec8c7..4d439972c14b 100644
> --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
> @@ -15,6 +15,7 @@ properties:
> - aspeed,ast2400-gpio
> - aspeed,ast2500-gpio
> - aspeed,ast2600-gpio
> + - aspeed,ast2700-gpio
>
> reg:
> maxItems: 1
> @@ -42,7 +43,7 @@ properties:
> const: 2
>
> ngpios:
> - minimum: 36
> + minimum: 12
> maximum: 232
Aren't you missing a corresponding update to gpio-line-names, which has
a minimum of 36?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-08-30 14:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 3:40 [PATCH v2 0/4] Add Aspeed G7 gpio support Billy Tsai
2024-08-30 3:40 ` [PATCH v2 1/4] dt-bindings: gpio: aspeed,ast2400-gpio: Support ast2700 Billy Tsai
2024-08-30 14:04 ` Conor Dooley [this message]
2024-09-02 2:32 ` Billy Tsai
2024-08-31 5:49 ` Krzysztof Kozlowski
2024-08-30 3:40 ` [PATCH v2 2/4] gpio: aspeed: Remove the name for bank array Billy Tsai
2024-09-12 7:51 ` Andrew Jeffery
2024-09-12 7:57 ` Billy Tsai
2024-08-30 3:40 ` [PATCH v2 3/4] gpio: aspeed: Create llops to handle hardware access Billy Tsai
2024-08-30 16:07 ` kernel test robot
2024-08-31 1:46 ` kernel test robot
2024-08-31 16:05 ` Dan Carpenter
2024-09-12 8:18 ` Andrew Jeffery
2024-08-30 3:40 ` [PATCH v2 4/4] gpio: aspeed: Support G7 Aspeed gpio controller Billy Tsai
2024-08-31 3:39 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830-untangled-charting-48503e510ea7@spud \
--to=conor@kernel.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=billy_tsai@aspeedtech.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).