linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod][PATCH] build: fix HAS_GI_DOCGEN never defined error
Date: Sat, 31 Aug 2024 15:52:12 +0800	[thread overview]
Message-ID: <20240831075212.147812-1-warthog618@gmail.com> (raw)

When building without --enable-bindings-glib configure reports this error:

  ...
  checking for help2man... true
  checking that generated files are newer than configure... done
  configure: error: conditional "HAS_GI_DOCGEN" was never defined.
  Usually this means the macro was only invoked conditionally.
  make: *** [Makefile:440: config.status] Error 1

Move the initialization of HAS_GI_DOCGEN outside the conditional
with_bindings_glib section so it is always initialized.

Fixes: e090088c21b7 ("bindings: add GLib bindings")
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---

Sorry about the resend - forgot the libgpiod prefix on the first try :(.

 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index cbe9e13..1ac1002 100644
--- a/configure.ac
+++ b/configure.ac
@@ -267,12 +267,12 @@ then
 		AC_MSG_ERROR([glib-mkenums not found - needed to build GLib bindings]))
 
 	AC_CHECK_PROG([has_gi_docgen], [gi-docgen], [true], [false])
-	AM_CONDITIONAL([HAS_GI_DOCGEN], [test "x$has_gi_docgen" = xtrue])
 	if test "x$has_gi_docgen" = xfalse
 	then
 		AC_MSG_NOTICE([gi-docgen not found - GLib documentation cannot be generated])
 	fi
 fi
+AM_CONDITIONAL([HAS_GI_DOCGEN], [test "x$has_gi_docgen" = xtrue])
 
 # GObject-introspection
 found_introspection=no
-- 
2.39.2


             reply	other threads:[~2024-08-31  7:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-31  7:52 Kent Gibson [this message]
2024-09-02  9:41 ` [libgpiod][PATCH] build: fix HAS_GI_DOCGEN never defined error Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240831075212.147812-1-warthog618@gmail.com \
    --to=warthog618@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).