[libgpiod][PATCH] build: fix HAS_GI_DOCGEN never defined error

[libgpiod][PATCH] build: fix HAS_GI_DOCGEN never defined error

[Kent Gibson]

When building without --enable-bindings-glib configure reports this error:

  ...
  checking for help2man... true
  checking that generated files are newer than configure... done
  configure: error: conditional "HAS_GI_DOCGEN" was never defined.
  Usually this means the macro was only invoked conditionally.
  make: *** [Makefile:440: config.status] Error 1

Move the initialization of HAS_GI_DOCGEN outside the conditional
with_bindings_glib section so it is always initialized.

Fixes: e090088c21b7 ("bindings: add GLib bindings")
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---

Sorry about the resend - forgot the libgpiod prefix on the first try :(.

 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index cbe9e13..1ac1002 100644
--- a/configure.ac
+++ b/configure.ac
@@ -267,12 +267,12 @@ then
 		AC_MSG_ERROR([glib-mkenums not found - needed to build GLib bindings]))
 
 	AC_CHECK_PROG([has_gi_docgen], [gi-docgen], [true], [false])
-	AM_CONDITIONAL([HAS_GI_DOCGEN], [test "x$has_gi_docgen" = xtrue])
 	if test "x$has_gi_docgen" = xfalse
 	then
 		AC_MSG_NOTICE([gi-docgen not found - GLib documentation cannot be generated])
 	fi
 fi
+AM_CONDITIONAL([HAS_GI_DOCGEN], [test "x$has_gi_docgen" = xtrue])
 
 # GObject-introspection
 found_introspection=no
-- 
2.39.2

Re: [libgpiod][PATCH] build: fix HAS_GI_DOCGEN never defined error

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Sat, 31 Aug 2024 15:52:12 +0800, Kent Gibson wrote:
> When building without --enable-bindings-glib configure reports this error:
> 
>   ...
>   checking for help2man... true
>   checking that generated files are newer than configure... done
>   configure: error: conditional "HAS_GI_DOCGEN" was never defined.
>   Usually this means the macro was only invoked conditionally.
>   make: *** [Makefile:440: config.status] Error 1
> 
> [...]

Applied, thanks!

[1/1] build: fix HAS_GI_DOCGEN never defined error
      commit: c701785717629ecb609764092414d1f164022d2a

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>