* [PATCH v1 1/1] pinctrl: baytrail: Drop duplicate return statement
@ 2024-09-03 15:47 Andy Shevchenko
2024-09-04 5:02 ` Mika Westerberg
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2024-09-03 15:47 UTC (permalink / raw)
To: Andy Shevchenko, linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij
No need to repeat 'return ret;' inside and outside conditional.
Just use one outside conditional for both cases.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index 6dab0316715b..ad6a5e7157ee 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1535,10 +1535,8 @@ static int byt_gpio_probe(struct intel_pinctrl *vg)
}
ret = devm_gpiochip_add_data(vg->dev, gc, vg);
- if (ret) {
+ if (ret)
dev_err(vg->dev, "failed adding byt-gpio chip\n");
- return ret;
- }
return ret;
}
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: baytrail: Drop duplicate return statement
2024-09-03 15:47 [PATCH v1 1/1] pinctrl: baytrail: Drop duplicate return statement Andy Shevchenko
@ 2024-09-04 5:02 ` Mika Westerberg
2024-09-04 10:30 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2024-09-04 5:02 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-gpio, linux-kernel, Andy Shevchenko, Linus Walleij
On Tue, Sep 03, 2024 at 06:47:55PM +0300, Andy Shevchenko wrote:
> No need to repeat 'return ret;' inside and outside conditional.
> Just use one outside conditional for both cases.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: baytrail: Drop duplicate return statement
2024-09-04 5:02 ` Mika Westerberg
@ 2024-09-04 10:30 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-09-04 10:30 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-gpio, linux-kernel, Linus Walleij
On Wed, Sep 04, 2024 at 08:02:08AM +0300, Mika Westerberg wrote:
> On Tue, Sep 03, 2024 at 06:47:55PM +0300, Andy Shevchenko wrote:
> > No need to repeat 'return ret;' inside and outside conditional.
> > Just use one outside conditional for both cases.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-04 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 15:47 [PATCH v1 1/1] pinctrl: baytrail: Drop duplicate return statement Andy Shevchenko
2024-09-04 5:02 ` Mika Westerberg
2024-09-04 10:30 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).