From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v2 2/3] pinctrl: baytrail: Replace ifdeffery by pm_sleep_ptr() macro
Date: Fri, 6 Sep 2024 14:36:07 +0300 [thread overview]
Message-ID: <20240906113710.467716-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240906113710.467716-1-andriy.shevchenko@linux.intel.com>
Explicit ifdeffery is ugly and theoretically might be not synchronised
with the rest of functions that are assigned via pm_sleep_ptr() macro.
Replace ifdeffery by pm_sleep_ptr() macro to improve this.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-baytrail.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index 4533c4d0a9e7..44a77ec1c8ed 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1514,13 +1514,6 @@ static int byt_gpio_probe(struct intel_pinctrl *vg)
gc->parent = vg->dev;
gc->ngpio = vg->soc->npins;
-#ifdef CONFIG_PM_SLEEP
- vg->context.pads = devm_kcalloc(vg->dev, gc->ngpio, sizeof(*vg->context.pads),
- GFP_KERNEL);
- if (!vg->context.pads)
- return -ENOMEM;
-#endif
-
/* set up interrupts */
irq = platform_get_irq_optional(pdev, 0);
if (irq > 0) {
@@ -1581,6 +1574,16 @@ static const struct acpi_device_id byt_gpio_acpi_match[] = {
{ }
};
+static int byt_pinctrl_pm_init(struct intel_pinctrl *vg)
+{
+ vg->context.pads = devm_kcalloc(vg->dev, vg->soc->npins,
+ sizeof(*vg->context.pads), GFP_KERNEL);
+ if (!vg->context.pads)
+ return -ENOMEM;
+
+ return 0;
+}
+
static int byt_pinctrl_probe(struct platform_device *pdev)
{
const struct intel_pinctrl_soc_data *soc_data;
@@ -1603,6 +1606,10 @@ static int byt_pinctrl_probe(struct platform_device *pdev)
return ret;
}
+ ret = intel_pinctrl_context_alloc(vg, byt_pinctrl_pm_init);
+ if (ret)
+ return ret;
+
vg->pctldesc = byt_pinctrl_desc;
vg->pctldesc.name = dev_name(dev);
vg->pctldesc.pins = vg->soc->pins;
--
2.43.0.rc1.1336.g36b5255a03ac
next prev parent reply other threads:[~2024-09-06 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 11:36 [PATCH v2 0/3] pinctrl: intel: Replace ifdeffery by pm_sleep_ptr() macro Andy Shevchenko Andy Shevchenko
2024-09-06 11:36 ` [PATCH v2 1/3] pinctrl: intel: Replace ifdeffery by pm_sleep_ptr() macro Andy Shevchenko
2024-09-06 12:02 ` Mika Westerberg
2024-09-06 11:36 ` Andy Shevchenko [this message]
2024-09-06 11:36 ` [PATCH v2 3/3] pinctrl: cherryview: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906113710.467716-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).