From: Conor Dooley <conor@kernel.org>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: ocelot: document lan969x-pinctrl
Date: Tue, 17 Sep 2024 13:36:09 +0100 [thread overview]
Message-ID: <20240917-squander-stunt-c6bec4409491@squawk> (raw)
In-Reply-To: <20240917075259.deuwi5s5gdqo3w6z@DEN-DL-M70577>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On Tue, Sep 17, 2024 at 07:52:59AM +0000, Daniel Machon wrote:
> > > reg:
> > > items:
> > > @@ -85,6 +95,12 @@ allOf:
> > > contains:
> > > enum:
> > > - microchip,lan966x-pinctrl
> > > + - microchip,lan9698-pinctrl
> > > + - microchip,lan9696-pinctrl
> > > + - microchip,lan9694-pinctrl
> > > + - microchip,lan9693-pinctrl
> > > + - microchip,lan9692-pinctrl
> >
> > > + - microchip,lan9691-pinctrl
> >
> > This should work on its own, since the other devices here have it as a
> > fallback.
>
> Just to be clear - we only need the "microchip,lan9691-pinctrl" here?
Ye, in the enum you should only need that compatible (in addition to the
exsting one) because lan9691 is the fallback for all the others and
therefore the compatible must contain it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-09-17 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 19:10 [PATCH 0/2] pinctrl: ocelot: add support for lan969x SoC Daniel Machon
2024-09-14 19:10 ` [PATCH 1/2] dt-bindings: ocelot: document lan969x-pinctrl Daniel Machon
2024-09-16 16:16 ` Conor Dooley
2024-09-17 7:52 ` Daniel Machon
2024-09-17 12:36 ` Conor Dooley [this message]
2024-09-17 12:40 ` Daniel Machon
2024-09-14 19:10 ` [PATCH 2/2] pinctrl: ocelot: add support for lan969x SoC pinctrl Daniel Machon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917-squander-stunt-c6bec4409491@squawk \
--to=conor@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).