* [PATCH] pinctrl: sx150x: Use maple tree register cache
@ 2024-09-24 15:39 Mark Brown
2024-10-01 14:30 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2024-09-24 15:39 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Mark Brown
The sx150x driver uses a rbtree register cache with no obvious reason for
specifically preferring it. The maple tree register cache is based on a
more modern data structure and makes implementation decisions more suitable
for modern systems so let's switch the driver to use that. No functional
change.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/pinctrl/pinctrl-sx150x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
index fd0331a87cda..ab87de319ad8 100644
--- a/drivers/pinctrl/pinctrl-sx150x.c
+++ b/drivers/pinctrl/pinctrl-sx150x.c
@@ -1105,7 +1105,7 @@ static const struct regmap_config sx150x_regmap_config = {
.reg_bits = 8,
.val_bits = 32,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.reg_read = sx150x_regmap_reg_read,
.reg_write = sx150x_regmap_reg_write,
---
base-commit: 98f7e32f20d28ec452afb208f9cffc08448a2652
change-id: 20240924-pinctl-sx150x-maple-d8c1f45b9629
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sx150x: Use maple tree register cache
2024-09-24 15:39 [PATCH] pinctrl: sx150x: Use maple tree register cache Mark Brown
@ 2024-10-01 14:30 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2024-10-01 14:30 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-gpio, linux-kernel
On Tue, Sep 24, 2024 at 5:39 PM Mark Brown <broonie@kernel.org> wrote:
> The sx150x driver uses a rbtree register cache with no obvious reason for
> specifically preferring it. The maple tree register cache is based on a
> more modern data structure and makes implementation decisions more suitable
> for modern systems so let's switch the driver to use that. No functional
> change.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-01 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 15:39 [PATCH] pinctrl: sx150x: Use maple tree register cache Mark Brown
2024-10-01 14:30 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).