From: Conor Dooley <conor@kernel.org>
To: pierre-henry.moussay@microchip.com
Cc: Linux4Microchip@microchip.com,
Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [linux][PATCH v2 05/20] dt-bindings: gpio: mpfs-gpio: Add PIC64GX GPIO compatibility
Date: Mon, 30 Sep 2024 14:46:14 +0100 [thread overview]
Message-ID: <20240930-mourner-sharpness-1b049c7e5c85@spud> (raw)
In-Reply-To: <20240930095449.1813195-6-pierre-henry.moussay@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
On Mon, Sep 30, 2024 at 10:54:34AM +0100, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
>
> PIC64GX GPIO is compatible with mpfs-gpio controller, just add fallback
>
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> ---
> .../bindings/gpio/microchip,mpfs-gpio.yaml | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> index d61569b3f15b..febe8c2cd70d 100644
> --- a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> @@ -11,10 +11,14 @@ maintainers:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - microchip,mpfs-gpio
> - - microchip,coregpio-rtl-v3
> + oneOf:
> + - items:
> + - const: microchip,pic64gx-gpio
> + - const: microchip,mpfs-gpio
> + - items:
This items shouldn't be required, the enum should suffice alone.
> + - enum:
> + - microchip,mpfs-gpio
> + - microchip,coregpio-rtl-v3
>
> reg:
> maxItems: 1
> @@ -69,7 +73,8 @@ allOf:
> properties:
> compatible:
> contains:
> - const: microchip,mpfs-gpio
> + enum:
> + - microchip,mpfs-gpio
This doesn't need to be changed, it is fine as is, no?
> then:
> required:
> - interrupts
> --
> 2.30.2
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-09-30 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240930095449.1813195-1-pierre-henry.moussay@microchip.com>
2024-09-30 9:54 ` [linux][PATCH v2 05/20] dt-bindings: gpio: mpfs-gpio: Add PIC64GX GPIO compatibility pierre-henry.moussay
2024-09-30 13:46 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930-mourner-sharpness-1b049c7e5c85@spud \
--to=conor@kernel.org \
--cc=Linux4Microchip@microchip.com \
--cc=brgl@bgdev.pl \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=pierre-henry.moussay@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).