* [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration
@ 2024-10-02 7:19 Vignesh Raghavendra
2024-10-02 10:24 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Vignesh Raghavendra @ 2024-10-02 7:19 UTC (permalink / raw)
To: Keerthy, Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, Vignesh Raghavendra, linux-arm-kernel,
Sabeeh Khan
Since commit d29e741cad3f ("gpio: davinci: drop platform data support"),
irqchip is no longer being registered on platforms what don't use
unbanked gpios. Fix this.
Reported-by: Sabeeh Khan <sabeeh-khan@ti.com>
Fixes: d29e741cad3f ("gpio: davinci: drop platform data support")
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 790595f3b949..76b58c70b257 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
return PTR_ERR(clk);
}
- if (chips->gpio_unbanked) {
+ if (!chips->gpio_unbanked) {
irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);
if (irq < 0) {
dev_err(dev, "Couldn't allocate IRQ numbers\n");
--
2.46.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration
2024-10-02 7:19 [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration Vignesh Raghavendra
@ 2024-10-02 10:24 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2024-10-02 10:24 UTC (permalink / raw)
To: Keerthy, Linus Walleij, Bartosz Golaszewski, Vignesh Raghavendra
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, linux-arm-kernel,
Sabeeh Khan
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Wed, 02 Oct 2024 12:49:01 +0530, Vignesh Raghavendra wrote:
> Since commit d29e741cad3f ("gpio: davinci: drop platform data support"),
> irqchip is no longer being registered on platforms what don't use
> unbanked gpios. Fix this.
>
>
My bad, thanks for spotting this.
Applied, thanks!
[1/1] gpio: gpio-davinci: Fix condition for irqchip registration
commit: 69e40c3ef27998105b3002434ee640800d376668
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-02 10:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 7:19 [PATCH] gpio: gpio-davinci: Fix condition for irqchip registration Vignesh Raghavendra
2024-10-02 10:24 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).