From: Linus Walleij <linus.walleij@linaro.org>
To: Ze Huang <18771902331@163.com>
Cc: linux-gpio@vger.kernel.org, kernel test robot <lkp@intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH] pinctrl: k230: Drop unused code
Date: Thu, 03 Oct 2024 16:44:43 +0200 [thread overview]
Message-ID: <20241003-k320-unused-v1-1-72e65bc2f27b@linaro.org> (raw)
The build robot complains about unused code. Let's drop it,
this can be restored with simple git revert when needed.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410021136.ie3cFM2w-lkp@intel.com/
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/pinctrl/pinctrl-k230.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-k230.c b/drivers/pinctrl/pinctrl-k230.c
index 4266516886fc..a9b4627b46b0 100644
--- a/drivers/pinctrl/pinctrl-k230.c
+++ b/drivers/pinctrl/pinctrl-k230.c
@@ -156,7 +156,7 @@ static void k230_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
struct seq_file *s, unsigned int offset)
{
struct k230_pinctrl *info = pinctrl_dev_get_drvdata(pctldev);
- u32 val, mode, bias, drive, input, output, slew, schmitt, power;
+ u32 val, bias, drive, input, slew, schmitt, power;
struct k230_pin_group *grp = k230_pins[offset].drv_data;
static const char * const biasing[] = {
"pull none", "pull down", "pull up", "" };
@@ -167,11 +167,9 @@ static void k230_pinctrl_pin_dbg_show(struct pinctrl_dev *pctldev,
regmap_read(info->regmap_base, offset * 4, &val);
- mode = (val & K230_PC_SEL) >> K230_SHIFT_SEL;
drive = (val & K230_PC_DS) >> K230_SHIFT_DS;
bias = (val & K230_PC_BIAS) >> K230_SHIFT_BIAS;
input = (val & K230_PC_IE) >> K230_SHIFT_IE;
- output = (val & K230_PC_OE) >> K230_SHIFT_OE;
slew = (val & K230_PC_SL) >> K230_SHIFT_SL;
schmitt = (val & K230_PC_ST) >> K230_SHIFT_ST;
power = (val & K230_PC_MSC) >> K230_SHIFT_MSC;
---
base-commit: 58414a31c5713afb5449fd74a26a843d34cc62e8
change-id: 20241003-k320-unused-5bcd643652c3
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
reply other threads:[~2024-10-03 14:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003-k320-unused-v1-1-72e65bc2f27b@linaro.org \
--to=linus.walleij@linaro.org \
--cc=18771902331@163.com \
--cc=linux-gpio@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).